Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Put Image component into Psammead #203

Closed
1 task done
sareh opened this issue Dec 13, 2018 · 2 comments
Closed
1 task done

Put Image component into Psammead #203

sareh opened this issue Dec 13, 2018 · 2 comments
Assignees

Comments

@sareh
Copy link
Contributor

sareh commented Dec 13, 2018

Is your feature request related to a problem? Please describe.
Create an Image component in Psammead, looking at the one in Simorgh:

Corresponding 'pull from Psammead' issue in Simorgh: bbc/simorgh#1077.

Note: update the README.md to include standard sections: https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-paragraph

Describe the solution you'd like
A PR in Psammead, which adds an Image component.

Describe alternatives you've considered
N/A

Testing notes
Check to make sure component displays (with styling) as expected in Storybook.

Dev insight: Unit tests (if any) will be transferred from Simorgh.

Additional context
N/A

@sareh sareh added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. alpha-3 labels Dec 13, 2018
@ChrisBAshton ChrisBAshton added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Dec 17, 2018
@ChrisBAshton
Copy link
Contributor

ChrisBAshton commented Dec 17, 2018

Blocked on bbc/simorgh#929

@ChrisBAshton ChrisBAshton added alpha-2 high priority and removed alpha-3 Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Dec 17, 2018
@sareh sareh mentioned this issue Dec 17, 2018
4 tasks
@ChrisBAshton ChrisBAshton removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Dec 17, 2018
@ChrisBAshton
Copy link
Contributor

bbc/simorgh#929 is proving more difficult than anticipated.

We can pick up #203 in the meantime, and then port across the AmpImg PR to Psammead once we've nailed it in Simorgh.

@dr3 dr3 self-assigned this Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants