This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Re-home Simorgh Figure in Psammead #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr3
suggested changes
Dec 17, 2018
Co-Authored-By: radiocontrolled <radiocontrolled@gmail.com>
dr3
reviewed
Dec 18, 2018
dr3
suggested changes
Dec 18, 2018
sareh
reviewed
Dec 18, 2018
pjlee11
previously approved these changes
Dec 19, 2018
Co-Authored-By: radiocontrolled <radiocontrolled@gmail.com>
ChrisBAshton
previously approved these changes
Dec 20, 2018
bcmn
reviewed
Dec 20, 2018
bcmn
approved these changes
Dec 20, 2018
ChrisBAshton
approved these changes
Dec 20, 2018
dr3
approved these changes
Dec 20, 2018
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #214
A PR adding the Figure component to Psammead (without all of the 'subcomponents').
This PR leaves out storybook stories for now as there would not be much to display, until Simorgh components such as Image are fully re-homed in Psammead.