Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecated attribute public_network_access_enabled #485

Conversation

ishuar
Copy link
Contributor

@ishuar ishuar commented Dec 7, 2023

Describe your changes

  • Removed deprecated attribute public_network_access_enabled

Issue number

N/A

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb
Copy link
Member

This pr should solve #400.

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ishuar for opening this pr! According to our previous discussion, would you please add public_network_access_enabled to azurerm_kubernetes_cluster's ignore_changes? Thanks!

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Potential Breaking Changes in 8be7910:
[delete] "Variables.brown_field_application_gateway_for_ingress.Name" from 'brown_field_application_gateway_for_ingress' to ''
[delete] "Variables.public_network_access_enabled.Name" from 'public_network_access_enabled' to ''
[delete] "Variables.green_field_application_gateway_for_ingress.Name" from 'green_field_application_gateway_for_ingress' to ''
[delete] "Variables.create_role_assignments_for_application_gateway.Name" from 'create_role_assignments_for_application_gateway' to ''
[update] "Variables.maintenance_window.Type" from 'object({
allowed = optional(list(object({
day = string
hours = set(number)
})), [
]),
not_allowed = optional(list(object({
end = string
start = string
})), []),
})' to 'object({
allowed = optional(list(object({
day = string
hours = set(number)
})), []),
not_allowed = optional(list(object({
end = string
start = string
})), []),
})'

@ishuar
Copy link
Contributor Author

ishuar commented Dec 8, 2023

Thanks @ishuar for opening this pr! According to our previous discussion, would you please add public_network_access_enabled to azurerm_kubernetes_cluster's ignore_changes? Thanks!

Just to confirm, only need to add in ignore_changes but still keep the attribute and variable definition?

@lonegunmanb
Copy link
Member

Thanks @ishuar for opening this pr! According to our previous discussion, would you please add public_network_access_enabled to azurerm_kubernetes_cluster's ignore_changes? Thanks!

Just to confirm, only need to add in ignore_changes but still keep the attribute and variable definition?

Confirmed, thanks!

@ishuar ishuar force-pushed the remove-deprecated-attribute-public_network_access_enabled branch from 8be7910 to 8d9cf0e Compare December 8, 2023 19:55
@lonegunmanb lonegunmanb changed the title Removed deprecated attribute public_network_access_enabled Ignore deprecated attribute public_network_access_enabled Dec 12, 2023
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ishuar, LGTM!

@lonegunmanb lonegunmanb merged commit f07f9f7 into Azure:main Dec 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants