Skip to content

Commit

Permalink
rm deprecated public_network_access_enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
ishuar committed Dec 7, 2023
1 parent 10a3fa9 commit 8be7910
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 32 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,6 @@ No modules.
| <a name="input_private_cluster_enabled"></a> [private\_cluster\_enabled](#input\_private\_cluster\_enabled) | If true cluster API server will be exposed only on internal IP address and available only in cluster vnet. | `bool` | `false` | no |
| <a name="input_private_cluster_public_fqdn_enabled"></a> [private\_cluster\_public\_fqdn\_enabled](#input\_private\_cluster\_public\_fqdn\_enabled) | (Optional) Specifies whether a Public FQDN for this Private Cluster should be added. Defaults to `false`. | `bool` | `false` | no |
| <a name="input_private_dns_zone_id"></a> [private\_dns\_zone\_id](#input\_private\_dns\_zone\_id) | (Optional) Either the ID of Private DNS Zone which should be delegated to this Cluster, `System` to have AKS manage this or `None`. In case of `None` you will need to bring your own DNS server and set up resolving, otherwise cluster will have issues after provisioning. Changing this forces a new resource to be created. | `string` | `null` | no |
| <a name="input_public_network_access_enabled"></a> [public\_network\_access\_enabled](#input\_public\_network\_access\_enabled) | (Optional) Whether public network access is allowed for this Kubernetes Cluster. Defaults to `true`. Changing this forces a new resource to be created. | `bool` | `true` | no |
| <a name="input_public_ssh_key"></a> [public\_ssh\_key](#input\_public\_ssh\_key) | A custom ssh key to control access to the AKS cluster. Changing this forces a new resource to be created. | `string` | `""` | no |
| <a name="input_rbac_aad"></a> [rbac\_aad](#input\_rbac\_aad) | (Optional) Is Azure Active Directory integration enabled? | `bool` | `true` | no |
| <a name="input_rbac_aad_admin_group_object_ids"></a> [rbac\_aad\_admin\_group\_object\_ids](#input\_rbac\_aad\_admin\_group\_object\_ids) | Object ID of groups with admin access. | `list(string)` | `null` | no |
Expand Down
15 changes: 7 additions & 8 deletions examples/multiple_node_pools/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,11 @@ locals {
module "aks" {
source = "../.."

prefix = "prefix-${random_id.prefix.hex}"
resource_group_name = local.resource_group.name
os_disk_size_gb = 60
public_network_access_enabled = false
sku_tier = "Standard"
rbac_aad = false
vnet_subnet_id = azurerm_subnet.test.id
node_pools = local.nodes
prefix = "prefix-${random_id.prefix.hex}"
resource_group_name = local.resource_group.name
os_disk_size_gb = 60
sku_tier = "Standard"
rbac_aad = false
vnet_subnet_id = azurerm_subnet.test.id
node_pools = local.nodes
}
1 change: 0 additions & 1 deletion examples/named_cluster/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ module "aks_cluster_name" {
cluster_log_analytics_workspace_name = "test-cluster"
cluster_name = "test-cluster"
disk_encryption_set_id = azurerm_disk_encryption_set.des.id
public_network_access_enabled = false
identity_ids = [azurerm_user_assigned_identity.test.id]
identity_type = "UserAssigned"
log_analytics_solution = {
Expand Down
1 change: 0 additions & 1 deletion examples/startup/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ module "aks" {
node_os_channel_upgrade = "NodeImage"
os_disk_size_gb = 60
private_cluster_enabled = true
public_network_access_enabled = false
rbac_aad = true
rbac_aad_managed = true
role_based_access_control_enabled = true
Expand Down
13 changes: 6 additions & 7 deletions examples/with_acr/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,10 @@ module "aks" {
attached_acr_id_map = {
example = azurerm_container_registry.example.id
}
public_network_access_enabled = false
network_plugin = "azure"
network_policy = "azure"
os_disk_size_gb = 60
sku_tier = "Standard"
rbac_aad = false
vnet_subnet_id = azurerm_subnet.test.id
network_plugin = "azure"
network_policy = "azure"
os_disk_size_gb = 60
sku_tier = "Standard"
rbac_aad = false
vnet_subnet_id = azurerm_subnet.test.id
}
11 changes: 5 additions & 6 deletions examples/without_monitor/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,11 @@ resource "azurerm_dns_zone" "aks_web_app_routing" {
module "aks_without_monitor" {
source = "../.."

prefix = "prefix2-${random_id.prefix.hex}"
resource_group_name = local.resource_group.name
admin_username = null
azure_policy_enabled = true
disk_encryption_set_id = azurerm_disk_encryption_set.des.id
public_network_access_enabled = false
prefix = "prefix2-${random_id.prefix.hex}"
resource_group_name = local.resource_group.name
admin_username = null
azure_policy_enabled = true
disk_encryption_set_id = azurerm_disk_encryption_set.des.id
#checkov:skip=CKV_AZURE_4:The logging is turn off for demo purpose. DO NOT DO THIS IN PRODUCTION ENVIRONMENT!
log_analytics_workspace_enabled = false
net_profile_pod_cidr = "10.1.0.0/16"
Expand Down
1 change: 0 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ resource "azurerm_kubernetes_cluster" "main" {
private_cluster_enabled = var.private_cluster_enabled
private_cluster_public_fqdn_enabled = var.private_cluster_public_fqdn_enabled
private_dns_zone_id = var.private_dns_zone_id
public_network_access_enabled = var.public_network_access_enabled
role_based_access_control_enabled = var.role_based_access_control_enabled
run_command_enabled = var.run_command_enabled
sku_tier = var.sku_tier
Expand Down
7 changes: 0 additions & 7 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -1083,13 +1083,6 @@ variable "private_dns_zone_id" {
description = "(Optional) Either the ID of Private DNS Zone which should be delegated to this Cluster, `System` to have AKS manage this or `None`. In case of `None` you will need to bring your own DNS server and set up resolving, otherwise cluster will have issues after provisioning. Changing this forces a new resource to be created."
}

variable "public_network_access_enabled" {
type = bool
default = true
description = "(Optional) Whether public network access is allowed for this Kubernetes Cluster. Defaults to `true`. Changing this forces a new resource to be created."
nullable = false
}

variable "public_ssh_key" {
type = string
default = ""
Expand Down

0 comments on commit 8be7910

Please sign in to comment.