Remove public_network_access_enabled entirely
#488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonegunmanb
had a problem deploying
to
acctests
GitHub Actions
Failure
|
Potential Breaking Changes in 717e3e8: |
lonegunmanb
had a problem deploying
to
acctests
GitHub Actions
Failure
|
@lonegunmanb @jiaweitao001 why we did not remove this also from the Line 525 in 632deec I noticed because I still get the deprecation warning. Should we remove it in a new PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pr plus #485 should solve #400. This pr removed
var.public_network_access_enabledsince it's deprecated.Issue number
#000
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!