Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR storage/resource-manager] [Storage] Set the SignedResource as optional in ListServiceSAS #2967

Merged
merged 2 commits into from
Jul 31, 2018

Conversation

AutorestCI
Copy link
Contributor

[Storage] Set the SignedResource as optional in ListServiceSAS
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jul 20, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-storage

You can install the package azure-mgmt-storage of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3463#egg=azure-mgmt-storage&subdirectory=azure-mgmt-storage"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3463#egg=azure-mgmt-storage&subdirectory=azure-mgmt-storage"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_3463
  • pip install -e ./azure-mgmt-storage

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_3463
  • pip wheel --no-deps ./azure-mgmt-storage

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #2967 into restapi_auto_storage/resource-manager will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           restapi_auto_storage/resource-manager    #2967      +/-   ##
=========================================================================
- Coverage                                  56.97%   56.97%   -0.01%     
=========================================================================
  Files                                       7805     7805              
  Lines                                     160285   160287       +2     
=========================================================================
  Hits                                       91325    91325              
- Misses                                     68960    68962       +2
Impacted Files Coverage Δ
...mgmt/storage/v2018_02_01/models/restriction_py3.py 55.55% <ø> (ø) ⬆️
...ure/mgmt/storage/v2018_02_01/models/restriction.py 55.55% <ø> (ø) ⬆️
...orage/v2018_02_01/models/service_sas_parameters.py 20.83% <ø> (ø) ⬆️
...mt/storage/v2018_02_01/models/operation_display.py 44.44% <0%> (-5.56%) ⬇️
...e/v2018_02_01/models/service_sas_parameters_py3.py 20.83% <100%> (ø) ⬆️
...torage/v2018_02_01/models/operation_display_py3.py 44.44% <50%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0684ed4...a70e266. Read the comment docs.

@AutorestCI AutorestCI merged commit b80d986 into restapi_auto_storage/resource-manager Jul 31, 2018
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #3052

lmazuel pushed a commit that referenced this pull request Aug 1, 2018
* [AutoPR storage/resource-manager] [Storage] Set the SignedResource as optional in ListServiceSAS (#2967)

* Generated from 7882bc39a752f3adf4c47186c926094ab65cedc9

[Storage] Set the SignedResource as optional in ListServiceSAS

* Generated from b36d0991a7cc9a7185fc6b7d7ef6919f63435234

[Storage] Fix a format issue.

* Storage 2.0.0
@lmazuel lmazuel deleted the restapi_auto_3463 branch August 1, 2018 23:23
lmazuel pushed a commit that referenced this pull request Jan 15, 2019
* [AutoPR redis/resource-manager] Swagger completeness for Redis Cache (#2055)

* Generated from adccbe159e32ef8112a0aadccc07d3c6c5390d11

Name change for notification

* Generated from fdcb7d3837ae11e3fe8af22e28dadb032c498672

Fixing code review comments in PR

* [AutoPR redis/resource-manager] Improve redis Swagger.  (#2485)

* Generated from d7abeaa6ae57648be6ecde4bc11c226d9c85166c

Improve redis Swagger. Documenting list all patchSchedules to fix #2968. Documenting the CheckNameAvailability.type property better to fix #2967. And use a realistic timespan value in PatchSchedule examples.

* Generated from 4f7e77b990601e0cc00b69a5870b50157525364d

Implementing suggested usability improvement for redis cache: by not modelling CheckNameAvailabilityParameters.resourceType as a string, it can instead be treated as a cosntant, so that the parameter becomes optional!

* Generated from 44e3bae7be1e5d63ad1531c7710d586f47405970

Backport to the Microsoft.cache/redis 2017-10-01 swagger (from 2018-03-01).

* [AutoPR redis/resource-manager] typo: redis/resource-manager/Microsoft.Cache (#3984)

* Generated from 5c7c95d799e03d2c657ef9b8864b02e26f895949

typo: redis/resource-manager/Microsoft.Cache

- subid -> subscriptionId
- properites -> properties
- occured -> occurred
- Trim trailing space

* Packaging update of azure-mgmt-redis

* Rebuild by #2091

* 6.0.0

* Redis packaging

* Record simple tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants