Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR redis/resource-manager] Swagger completeness for Redis Cache #2055

Merged
merged 2 commits into from
Mar 2, 2018

Conversation

AutorestCI
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #2055 into restapi_auto_redis/resource-manager will decrease coverage by <.01%.
The diff coverage is 42.34%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##           restapi_auto_redis/resource-manager    #2055      +/-   ##
=======================================================================
- Coverage                                53.06%   53.06%   -0.01%     
=======================================================================
  Files                                     4774     4777       +3     
  Lines                                   119483   119571      +88     
=======================================================================
+ Hits                                     63406    63451      +45     
- Misses                                   56077    56120      +43
Impacted Files Coverage Δ
...ure-mgmt-redis/azure/mgmt/redis/models/__init__.py 100% <100%> (ø) ⬆️
...is/azure/mgmt/redis/operations/redis_operations.py 29.2% <28.81%> (+0.36%) ⬆️
.../mgmt/redis/operations/linked_server_operations.py 21.69% <50%> (+3.07%) ⬆️
...mgmt/redis/operations/firewall_rules_operations.py 21.97% <50%> (+3.58%) ⬆️
...mt-redis/azure/mgmt/redis/operations/operations.py 43.75% <50%> (+1.81%) ⬆️
...is/azure/mgmt/redis/models/upgrade_notification.py 55.55% <55.55%> (ø)
...redis/models/check_name_availability_parameters.py 57.14% <57.14%> (ø)
...gmt/redis/operations/patch_schedules_operations.py 27.14% <57.14%> (+4.41%) ⬆️
...re/mgmt/redis/models/notification_list_response.py 62.5% <62.5%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f896c05...5c85811. Read the comment docs.

@AutorestCI AutorestCI merged commit ce9aa1a into restapi_auto_redis/resource-manager Mar 2, 2018
@lmazuel lmazuel deleted the restapi_auto_2537 branch March 7, 2018 18:00
AutorestCI added a commit that referenced this pull request Mar 7, 2018
…2055)

* Generated from adccbe159e32ef8112a0aadccc07d3c6c5390d11

Name change for notification

* Generated from fdcb7d3837ae11e3fe8af22e28dadb032c498672

Fixing code review comments in PR
lmazuel pushed a commit that referenced this pull request Jan 15, 2019
* [AutoPR redis/resource-manager] Swagger completeness for Redis Cache (#2055)

* Generated from adccbe159e32ef8112a0aadccc07d3c6c5390d11

Name change for notification

* Generated from fdcb7d3837ae11e3fe8af22e28dadb032c498672

Fixing code review comments in PR

* [AutoPR redis/resource-manager] Improve redis Swagger.  (#2485)

* Generated from d7abeaa6ae57648be6ecde4bc11c226d9c85166c

Improve redis Swagger. Documenting list all patchSchedules to fix #2968. Documenting the CheckNameAvailability.type property better to fix #2967. And use a realistic timespan value in PatchSchedule examples.

* Generated from 4f7e77b990601e0cc00b69a5870b50157525364d

Implementing suggested usability improvement for redis cache: by not modelling CheckNameAvailabilityParameters.resourceType as a string, it can instead be treated as a cosntant, so that the parameter becomes optional!

* Generated from 44e3bae7be1e5d63ad1531c7710d586f47405970

Backport to the Microsoft.cache/redis 2017-10-01 swagger (from 2018-03-01).

* [AutoPR redis/resource-manager] typo: redis/resource-manager/Microsoft.Cache (#3984)

* Generated from 5c7c95d799e03d2c657ef9b8864b02e26f895949

typo: redis/resource-manager/Microsoft.Cache

- subid -> subscriptionId
- properites -> properties
- occured -> occurred
- Trim trailing space

* Packaging update of azure-mgmt-redis

* Rebuild by #2091

* 6.0.0

* Redis packaging

* Record simple tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants