[Storage] Set the SignedResource as optional in ListServiceSAS #3463

blueww · 2018-07-20T03:50:40Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

The rest spec set it as required before. But as feature team check on the Server, this should be optional.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-07-20T03:51:48Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3052

AutorestCI · 2018-07-20T03:51:57Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3266

AutorestCI · 2018-07-20T03:52:50Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1415

AutorestCI · 2018-07-20T03:54:19Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2134

AutorestCI · 2018-07-20T03:55:15Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2367

marstr · 2018-07-20T17:08:17Z

Heads up there are some troubles with the examples, you can see them enumerated here:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/406092205#L753

However, it's pretty clear to me that they weren't introduced by this PR, so I won't block on it.

blueww · 2018-07-23T06:17:16Z

@marstr
I have added the description property to swagger to fix the issue in example.
Not sure why this issue not reported before, as the code is not new.

Would you please help to review and merge?
I need to send the SRP SDK PR after this PR is merged.

blueww · 2018-07-24T02:29:57Z

@marstr

Let me know if anything blocks the merge, I need send the SDK PR after the swagger PR is merged.

blueww · 2018-07-27T06:18:35Z

@marstr
Could you please help to merge this PR is no other comments?
The PR has last for several days.

marstr · 2018-07-30T16:26:57Z

Howdy @blueww,

This PR has been waiting for ARM review (as per the label), however given that this is a relatively minor PR, we can merge it without their approval. However, if they raise concerns later, you may still have to address those concerns.

With those caveats, would you like me to merge this now?

blueww · 2018-07-31T02:33:36Z

@marstr
Yes, I would appreciate it if you can merge it ASAP.

azuresdkci · 2018-07-31T02:33:38Z

Can one of the admins verify this patch?

jhendrixMSFT · 2018-08-01T22:27:04Z

@AutorestCI regenerate azure-sdk-for-go

* test breaking change mlc in js (#3451) * ` * ` * Revert "`" This reverts commit c26fc6a. * Update specificationRepositoryConfiguration.json (#3457) * Update specificationRepositoryConfiguration.json (#3459) * Update specificationRepositoryConfiguration.json (#3462) Revert python repo branch change as it was deleted. * Update specificationRepositoryConfiguration.json (#3463) * Migrate typespec-validation.yml to GH Actions * path, fetch depth * Introduce error * Test a feature that AI says will collapse logs (doubtful it'll work) * Revert "Test a feature that AI says will collapse logs (doubtful it'll work)" This reverts commit 04aed83. * Log $LASTEXITCODE * Invalid syntax * Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE * Errors also get annotations in GitHub Actions * String replacement * Revert Logging-Functions.ps1 * Test composite action * File location * Invocation * Add typespec-validation-all.yml * Migrate typespec-validation-all.yml * Revert main.tsp invalid spec * fetch-depth: 2 * Long paths * checkout@v4 * Remove pipelines * *.yml -> *.yaml * Do not change specificationRepositoryConfiguration.json * Job names (for checks) * Add Skip/Take logic and matrix * Syntax * Rename * Remove "shell" * Try defaults.run.shell (unlikely to work) * bash * Name for actions/setup-node@v4 does not appear in the logs. Remove. * Use sharding semantics * Shard * Review feedback * Review feedback * +1 * Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions. This reverts commit 035bec7. * Shard only if TotalShards > 0 * Remove description (schema validaiton does not pass, let's see what GH Actions says) * The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it. * Add array functions and tests * Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate) * Add trailing newline * Add trailing newline * Update .github/workflows/typespec-validation.yaml Co-authored-by: Mike Harder <mharder@microsoft.com> * Review feedback * Update eng/scripts/TypeSpec-Validation.ps1 Co-authored-by: Mike Harder <mharder@microsoft.com> --------- Co-authored-by: Wanpeng Li <wanl@microsoft.com> Co-authored-by: Peng Jiahui <46921893+Alancere@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Ray Chen <raychen@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

* test breaking change mlc in js (Azure#3451) * ` * ` * Revert "`" This reverts commit c26fc6a. * Update specificationRepositoryConfiguration.json (Azure#3457) * Update specificationRepositoryConfiguration.json (Azure#3459) * Update specificationRepositoryConfiguration.json (Azure#3462) Revert python repo branch change as it was deleted. * Update specificationRepositoryConfiguration.json (Azure#3463) * Migrate typespec-validation.yml to GH Actions * path, fetch depth * Introduce error * Test a feature that AI says will collapse logs (doubtful it'll work) * Revert "Test a feature that AI says will collapse logs (doubtful it'll work)" This reverts commit 04aed83. * Log $LASTEXITCODE * Invalid syntax * Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE * Errors also get annotations in GitHub Actions * String replacement * Revert Logging-Functions.ps1 * Test composite action * File location * Invocation * Add typespec-validation-all.yml * Migrate typespec-validation-all.yml * Revert main.tsp invalid spec * fetch-depth: 2 * Long paths * checkout@v4 * Remove pipelines * *.yml -> *.yaml * Do not change specificationRepositoryConfiguration.json * Job names (for checks) * Add Skip/Take logic and matrix * Syntax * Rename * Remove "shell" * Try defaults.run.shell (unlikely to work) * bash * Name for actions/setup-node@v4 does not appear in the logs. Remove. * Use sharding semantics * Shard * Review feedback * Review feedback * +1 * Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions. This reverts commit 035bec7. * Shard only if TotalShards > 0 * Remove description (schema validaiton does not pass, let's see what GH Actions says) * The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it. * Add array functions and tests * Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate) * Add trailing newline * Add trailing newline * Update .github/workflows/typespec-validation.yaml Co-authored-by: Mike Harder <mharder@microsoft.com> * Review feedback * Update eng/scripts/TypeSpec-Validation.ps1 Co-authored-by: Mike Harder <mharder@microsoft.com> --------- Co-authored-by: Wanpeng Li <wanl@microsoft.com> Co-authored-by: Peng Jiahui <46921893+Alancere@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Ray Chen <raychen@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

[Storage] Set the SignedResource as optional in ListServiceSAS

7882bc3

azuresdkci assigned marstr Jul 20, 2018

azuresdkci requested a review from marstr July 20, 2018 03:51

AutorestCI mentioned this pull request Jul 20, 2018

[AutoPR storage/resource-manager] [Storage] Set the SignedResource as optional in ListServiceSAS Azure/azure-sdk-for-ruby#1500

Merged

marstr approved these changes Jul 20, 2018

View reviewed changes

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 20, 2018

[Storage] Fix a format issue.

b36d099

marstr merged commit 1dae0d5 into Azure:master Jul 31, 2018

blueww mentioned this pull request Aug 1, 2018

[Storage] Make SignedResource not required in listSericeSAS Azure/azure-sdk-for-net#4615

Merged

9 tasks

AutorestCI mentioned this pull request Aug 1, 2018

[AutoPR storage/resource-manager] [Storage] Set the SignedResource as optional in ListServiceSAS Azure/azure-sdk-for-go#2366

Merged

danieljurek pushed a commit that referenced this pull request Oct 15, 2024

Update specificationRepositoryConfiguration.json (#3463)

2806029

danieljurek pushed a commit that referenced this pull request Oct 15, 2024

Update specificationRepositoryConfiguration.json (#3463)

15e1ed6

danieljurek pushed a commit that referenced this pull request Oct 15, 2024

Update specificationRepositoryConfiguration.json (#3463)

cf7d123

danieljurek pushed a commit that referenced this pull request Oct 16, 2024

Update specificationRepositoryConfiguration.json (#3463)

b3389be

danieljurek pushed a commit that referenced this pull request Oct 24, 2024

Update specificationRepositoryConfiguration.json (#3463)

885a8ed

danieljurek pushed a commit that referenced this pull request Oct 25, 2024

Update specificationRepositoryConfiguration.json (#3463)

b551584

danieljurek pushed a commit that referenced this pull request Oct 25, 2024

Update specificationRepositoryConfiguration.json (#3463)

1ebe623

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] Set the SignedResource as optional in ListServiceSAS #3463

[Storage] Set the SignedResource as optional in ListServiceSAS #3463

blueww commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

marstr commented Jul 20, 2018

blueww commented Jul 23, 2018 •

edited

Loading

blueww commented Jul 24, 2018

blueww commented Jul 27, 2018

marstr commented Jul 30, 2018

blueww commented Jul 31, 2018

azuresdkci commented Jul 31, 2018

jhendrixMSFT commented Aug 1, 2018

[Storage] Set the SignedResource as optional in ListServiceSAS #3463

[Storage] Set the SignedResource as optional in ListServiceSAS #3463

Conversation

blueww commented Jul 20, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Jul 20, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 20, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jul 20, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jul 20, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jul 20, 2018 • edited Loading

Automation for azure-sdk-for-go

marstr commented Jul 20, 2018

blueww commented Jul 23, 2018 • edited Loading

blueww commented Jul 24, 2018

blueww commented Jul 27, 2018

marstr commented Jul 30, 2018

blueww commented Jul 31, 2018

azuresdkci commented Jul 31, 2018

jhendrixMSFT commented Aug 1, 2018

blueww commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

AutorestCI commented Jul 20, 2018 •

edited

Loading

blueww commented Jul 23, 2018 •

edited

Loading