Add API for adding external storage account configurations to a web app #3459

ebencarek · 2018-07-19T21:27:33Z

Redo of #3452, which was merged accidentally. The API is not live yet.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

ebencarek · 2018-07-19T21:28:31Z

Do not merge this yet. Redo of #3452, which was merged accidentally. The API is not live yet.

AutorestCI · 2018-07-19T21:29:29Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2065

dsgouda

LGTM for the most part, please address the comment

dsgouda · 2018-07-19T21:46:37Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/CommonDefinitions.json

+    "AzureStorageInfoValue": {
+      "description": "Azure Files or Blob Storage access information value for dictionary storage.",
+      "type": "object",
+      "properties": {


nit: Please check if any of these properties are readOnly

State should be readOnly, fixed in latest commit.

AutorestCI · 2018-07-19T21:56:00Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 6d27bba7ae39d02cdf7f4b62342113f6dddb5565
  stderr: 'fatal: reference is not a tree: 6d27bba7ae39d02cdf7f4b62342113f6dddb5565'

AutorestCI · 2018-07-19T22:05:16Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2392

dsgouda

LGTM

dsgouda · 2018-07-19T22:31:14Z

@ebencarek Let me know when this is ready to merge

AutorestCI · 2018-07-19T22:49:45Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3267

AutorestCI · 2018-07-19T23:41:49Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2218

dsgouda · 2018-07-30T18:28:04Z

@ebencarek Please let us know when this is ready to be merged. Will close this week if there is no activity on the PR.

azuresdkci · 2018-07-30T18:28:06Z

Can one of the admins verify this patch?

ebencarek · 2018-07-30T18:42:02Z

@dsgouda This should be ready to merge on Friday.

dsgouda · 2018-07-30T18:43:32Z

Please post on the PR once ready.

dsgouda · 2018-08-02T23:26:40Z

@ebencarek gentle almost-Friday ping

ebencarek · 2018-08-03T17:47:05Z

@dsgouda Go ahead and merge. Thanks!

dsgouda · 2018-08-03T18:08:17Z

@azuresdkci Retest this please

lmazuel · 2018-08-07T16:44:50Z

@AutorestCI rebuild azure-sdk-for-python

* test breaking change mlc in js (#3451) * ` * ` * Revert "`" This reverts commit c26fc6a. * Update specificationRepositoryConfiguration.json (#3457) * Update specificationRepositoryConfiguration.json (#3459) * Update specificationRepositoryConfiguration.json (#3462) Revert python repo branch change as it was deleted. * Update specificationRepositoryConfiguration.json (#3463) * Migrate typespec-validation.yml to GH Actions * path, fetch depth * Introduce error * Test a feature that AI says will collapse logs (doubtful it'll work) * Revert "Test a feature that AI says will collapse logs (doubtful it'll work)" This reverts commit 04aed83. * Log $LASTEXITCODE * Invalid syntax * Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE * Errors also get annotations in GitHub Actions * String replacement * Revert Logging-Functions.ps1 * Test composite action * File location * Invocation * Add typespec-validation-all.yml * Migrate typespec-validation-all.yml * Revert main.tsp invalid spec * fetch-depth: 2 * Long paths * checkout@v4 * Remove pipelines * *.yml -> *.yaml * Do not change specificationRepositoryConfiguration.json * Job names (for checks) * Add Skip/Take logic and matrix * Syntax * Rename * Remove "shell" * Try defaults.run.shell (unlikely to work) * bash * Name for actions/setup-node@v4 does not appear in the logs. Remove. * Use sharding semantics * Shard * Review feedback * Review feedback * +1 * Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions. This reverts commit 035bec7. * Shard only if TotalShards > 0 * Remove description (schema validaiton does not pass, let's see what GH Actions says) * The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it. * Add array functions and tests * Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate) * Add trailing newline * Add trailing newline * Update .github/workflows/typespec-validation.yaml Co-authored-by: Mike Harder <mharder@microsoft.com> * Review feedback * Update eng/scripts/TypeSpec-Validation.ps1 Co-authored-by: Mike Harder <mharder@microsoft.com> --------- Co-authored-by: Wanpeng Li <wanl@microsoft.com> Co-authored-by: Peng Jiahui <46921893+Alancere@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Ray Chen <raychen@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

* test breaking change mlc in js (Azure#3451) * ` * ` * Revert "`" This reverts commit c26fc6a. * Update specificationRepositoryConfiguration.json (Azure#3457) * Update specificationRepositoryConfiguration.json (Azure#3459) * Update specificationRepositoryConfiguration.json (Azure#3462) Revert python repo branch change as it was deleted. * Update specificationRepositoryConfiguration.json (Azure#3463) * Migrate typespec-validation.yml to GH Actions * path, fetch depth * Introduce error * Test a feature that AI says will collapse logs (doubtful it'll work) * Revert "Test a feature that AI says will collapse logs (doubtful it'll work)" This reverts commit 04aed83. * Log $LASTEXITCODE * Invalid syntax * Use error logging, remove continue-on-error because that is different behavior in GitHub Actions compared to ignoreLASTEXITCODE * Errors also get annotations in GitHub Actions * String replacement * Revert Logging-Functions.ps1 * Test composite action * File location * Invocation * Add typespec-validation-all.yml * Migrate typespec-validation-all.yml * Revert main.tsp invalid spec * fetch-depth: 2 * Long paths * checkout@v4 * Remove pipelines * *.yml -> *.yaml * Do not change specificationRepositoryConfiguration.json * Job names (for checks) * Add Skip/Take logic and matrix * Syntax * Rename * Remove "shell" * Try defaults.run.shell (unlikely to work) * bash * Name for actions/setup-node@v4 does not appear in the logs. Remove. * Use sharding semantics * Shard * Review feedback * Review feedback * +1 * Revert "Shard"... Display is confusing because it starts at 0 and doesn't reach total-shards. Math is not allowed in expressions. This reverts commit 035bec7. * Shard only if TotalShards > 0 * Remove description (schema validaiton does not pass, let's see what GH Actions says) * The `description` property is not absolutely required by GH Actions at this time but adding back in because schema requires it. * Add array functions and tests * Move Copy-ApiVersion.Tests.ps1 out of folder (adjust paths so they are accurate) * Add trailing newline * Add trailing newline * Update .github/workflows/typespec-validation.yaml Co-authored-by: Mike Harder <mharder@microsoft.com> * Review feedback * Update eng/scripts/TypeSpec-Validation.ps1 Co-authored-by: Mike Harder <mharder@microsoft.com> --------- Co-authored-by: Wanpeng Li <wanl@microsoft.com> Co-authored-by: Peng Jiahui <46921893+Alancere@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Ray Chen <raychen@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com>

Add API for adding external storage account configurations to a web app

783f10d

azuresdkci assigned dsgouda Jul 19, 2018

azuresdkci requested a review from dsgouda July 19, 2018 21:28

dsgouda suggested changes Jul 19, 2018

View reviewed changes

dsgouda added the Changes Required label Jul 19, 2018

Make state of AzureStorageInfoValue readonly

b3ca48c

AutorestCI mentioned this pull request Jul 19, 2018

[AutoPR web/resource-manager] [DO NOT MERGE] Add API for adding external storage account configurations to a web app Azure/azure-sdk-for-python#2964

Closed

dsgouda approved these changes Jul 19, 2018

View reviewed changes

AutorestCI mentioned this pull request Jul 19, 2018

[AutoPR web/resource-manager] [DO NOT MERGE] Add API for adding external storage account configurations to a web app Azure/azure-sdk-for-node#3204

Merged

AutorestCI mentioned this pull request Jul 19, 2018

[AutoPR web/resource-manager] [DO NOT MERGE] Add API for adding external storage account configurations to a web app Azure/azure-sdk-for-java#2243

Merged

dsgouda added DoNotMerge <valid label in PR review process> use to hold merge after approval and removed Changes Required labels Jul 20, 2018

ebencarek changed the title ~~[DO NOT MERGE] Add API for adding external storage account configurations to a web app~~ Add API for adding external storage account configurations to a web app Aug 3, 2018

dsgouda removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 3, 2018

dsgouda merged commit 75e6be3 into Azure:master Aug 3, 2018

AutorestCI mentioned this pull request Aug 3, 2018

[AutoPR web/resource-manager] Add API for adding external storage account configurations to a web app Azure/azure-sdk-for-go#2391

Merged

danieljurek pushed a commit that referenced this pull request Oct 15, 2024

Update specificationRepositoryConfiguration.json (#3459)

0bc7c1e

danieljurek pushed a commit that referenced this pull request Oct 15, 2024

Update specificationRepositoryConfiguration.json (#3459)

b574bf9

danieljurek pushed a commit that referenced this pull request Oct 15, 2024

Update specificationRepositoryConfiguration.json (#3459)

a997ae5

danieljurek pushed a commit that referenced this pull request Oct 16, 2024

Update specificationRepositoryConfiguration.json (#3459)

2b146b9

danieljurek pushed a commit that referenced this pull request Oct 24, 2024

Update specificationRepositoryConfiguration.json (#3459)

a9cf93b

danieljurek pushed a commit that referenced this pull request Oct 25, 2024

Update specificationRepositoryConfiguration.json (#3459)

5cf8998

danieljurek pushed a commit that referenced this pull request Oct 25, 2024

Update specificationRepositoryConfiguration.json (#3459)

808ea5f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add API for adding external storage account configurations to a web app #3459

Add API for adding external storage account configurations to a web app #3459

ebencarek commented Jul 19, 2018 •

edited by azuresdkci

Loading

ebencarek commented Jul 19, 2018

AutorestCI commented Jul 19, 2018 •

edited

Loading

dsgouda left a comment

dsgouda Jul 19, 2018

ebencarek Jul 19, 2018

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

dsgouda left a comment

dsgouda commented Jul 19, 2018

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

dsgouda commented Jul 30, 2018

azuresdkci commented Jul 30, 2018

ebencarek commented Jul 30, 2018

dsgouda commented Jul 30, 2018

dsgouda commented Aug 2, 2018

ebencarek commented Aug 3, 2018

dsgouda commented Aug 3, 2018

lmazuel commented Aug 7, 2018

Add API for adding external storage account configurations to a web app #3459

Add API for adding external storage account configurations to a web app #3459

Conversation

ebencarek commented Jul 19, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

ebencarek commented Jul 19, 2018

AutorestCI commented Jul 19, 2018 • edited Loading

Automation for azure-sdk-for-python

dsgouda left a comment

Choose a reason for hiding this comment

dsgouda Jul 19, 2018

Choose a reason for hiding this comment

ebencarek Jul 19, 2018

Choose a reason for hiding this comment

AutorestCI commented Jul 19, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jul 19, 2018 • edited Loading

Automation for azure-sdk-for-go

dsgouda left a comment

Choose a reason for hiding this comment

dsgouda commented Jul 19, 2018

AutorestCI commented Jul 19, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jul 19, 2018 • edited Loading

Automation for azure-sdk-for-java

dsgouda commented Jul 30, 2018

azuresdkci commented Jul 30, 2018

ebencarek commented Jul 30, 2018

dsgouda commented Jul 30, 2018

dsgouda commented Aug 2, 2018

ebencarek commented Aug 3, 2018

dsgouda commented Aug 3, 2018

lmazuel commented Aug 7, 2018

ebencarek commented Jul 19, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading