[AutoPr] monitor/resource-manager #1931

lmazuel · 2018-02-08T01:50:15Z

No description provided.

codecov-io · 2018-02-08T02:13:24Z

Codecov Report

Merging #1931 into master will decrease coverage by 2.21%.
The diff coverage is 51.19%.

@@            Coverage Diff             @@
##           master    #1931      +/-   ##
==========================================
- Coverage   53.06%   50.85%   -2.22%     
==========================================
  Files        4774     5626     +852     
  Lines      119483   144305   +24822     
==========================================
+ Hits        63406    73386    +9980     
- Misses      56077    70919   +14842

Impacted Files	Coverage Δ
...azure/mgmt/monitor/models/action_group_resource.py	`35.71% <10%> (-9.75%)`	⬇️
...onitor/azure/mgmt/monitor/models/metric_trigger.py	`35.71% <10%> (-2.75%)`	⬇️
...ure/mgmt/monitor/models/rule_metric_data_source.py	`100% <100%> (ø)`	⬆️
...r/azure/mgmt/monitor/models/alert_rule_resource.py	`100% <100%> (ø)`	⬆️
...-monitor/azure/mgmt/monitor/operations/__init__.py	`100% <100%> (ø)`	⬆️
...r/azure/mgmt/monitor/models/time_series_element.py	`100% <100%> (ø)`	⬆️
...itor/azure/mgmt/monitor/models/rule_data_source.py	`100% <100%> (ø)`	⬆️
...re/mgmt/monitor/models/threshold_rule_condition.py	`100% <100%> (ø)`	⬆️
...onitor/azure/mgmt/monitor/models/rule_condition.py	`100% <100%> (ø)`	⬆️
...tor/azure/mgmt/monitor/models/rule_email_action.py	`100% <100%> (ø)`	⬆️
... and 1251 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f746c62...b779c2d. Read the comment docs.

lmazuel · 2018-02-16T21:32:23Z

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/readme.md

AutorestCI · 2018-02-16T21:33:17Z

Build SDK finished and cleaned

lmazuel · 2018-02-16T21:41:36Z

@AutorestCI install

AutorestCI · 2018-02-16T21:41:39Z

Installation instruction

Package azure-mgmt-monitor

You can install the package azure-mgmt-monitor of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_monitor/resource-manager#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_monitor/resource-manager#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

If you have a local clone of this repository, you can also do:

git checkout restapi_auto_monitor/resource-manager
pip install -e ./azure-mgmt-monitor

Or build a wheel file to distribute for testing:

git checkout restapi_auto_monitor/resource-manager
pip wheel --no-deps ./azure-mgmt-monitor

lmazuel · 2018-02-28T18:17:54Z

@AutorestCI rebase

* Generated from e6af07c * Update Monitor version

fix python sdk failure

[Monitor] Make all attributes of EventData class readonly (#2254)

Update monitor Py conf

… 2018-01-01 version for metrics API (#2007) * Generated from 25392731dd0415e1e5700412428dd5a96a2d7813 Fix PR comments 1 * Generated from f6739fd0e07e3d040fc0b1f47f3297a7a4a69cba Fixing top/orderby names, Please be reminded, there is no code change, it's just a typo of the names. * Generated from 8ddf699be2bc7bd7a429b97db29d4abb3f238cad Fix meta data sample as well.

AutorestCI · 2018-02-28T18:22:59Z

Rebase done and pushed to the branch

[Monitor] Fixing issue with metricnamespace specification as client level argument #2565

[Monitor] Fixing issue with metrics api queryparameter name (#2575)

[Monitor] Fixing incorrect specification of top parameter for Metrics API (#2655)

AutorestCI · 2018-03-14T23:46:43Z

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-monitor

You can install the package azure-mgmt-monitor of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_monitor/resource-manager#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_monitor/resource-manager#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

If you have a local clone of this repository, you can also do:

git checkout restapi_auto_monitor/resource-manager
pip install -e ./azure-mgmt-monitor

Or build a wheel file to distribute for testing:

git checkout restapi_auto_monitor/resource-manager
pip wheel --no-deps ./azure-mgmt-monitor

Direct download

Your files can be directly downloaded here:

Support azureFunctionReceivers in actionGroup APIs

lmazuel · 2018-03-16T19:16:33Z

azure-mgmt-monitor/azure/mgmt/monitor/monitor_management_client.py

@@ -96,6 +97,8 @@ class MonitorManagementClient(object):
    :vartype metric_definitions: azure.mgmt.monitor.operations.MetricDefinitionsOperations
    :ivar metrics: Metrics operations
    :vartype metrics: azure.mgmt.monitor.operations.MetricsOperations
+    :ivar metric_baseline: MetricBaseline operations


New operation group

lmazuel · 2018-03-16T19:16:52Z

azure-mgmt-monitor/azure/mgmt/monitor/models/action_group_resource.py

@@ -66,12 +79,18 @@ class ActionGroupResource(Resource):
        'email_receivers': {'key': 'properties.emailReceivers', 'type': '[EmailReceiver]'},
        'sms_receivers': {'key': 'properties.smsReceivers', 'type': '[SmsReceiver]'},
        'webhook_receivers': {'key': 'properties.webhookReceivers', 'type': '[WebhookReceiver]'},
+        'itsm_receivers': {'key': 'properties.itsmReceivers', 'type': '[ItsmReceiver]'},


new attribute

lmazuel · 2018-03-16T19:19:10Z

azure-mgmt-monitor/azure/mgmt/monitor/operations/action_groups_operations.py


        if response.status_code not in [200, 204]:
            raise models.ErrorResponseException(self._deserialize, response)

        if raw:
            client_raw_response = ClientRawResponse(None, response)
            return client_raw_response
+    delete.metadata = {'url': '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/actionGroups/{actionGroupName}'}
+
+    def update(


lmazuel · 2018-03-16T19:19:39Z

azure-mgmt-monitor/azure/mgmt/monitor/operations/autoscale_settings_operations.py

    :ivar api_version: Client Api Version. Constant value: "2015-04-01".
    """

+    models = models


lmazuel · 2018-03-16T19:20:00Z

azure-mgmt-monitor/azure/mgmt/monitor/operations/metrics_operations.py

    def __init__(self, client, config, serializer, deserializer):

        self._client = client
        self._serialize = serializer
        self._deserialize = deserializer
-        self.api_version = "2017-05-01-preview"
+        self.api_version = "2018-01-01"


new api version

lmazuel · 2018-03-16T19:20:18Z

azure-mgmt-monitor/azure/mgmt/monitor/operations/metrics_operations.py

@@ -45,15 +47,16 @@ def list(
        :type timespan: str
        :param interval: The interval (i.e. timegrain) of the query.
        :type interval: timedelta
-        :param metric: The name of the metric to retrieve.
-        :type metric: str
+        :param metricnames: The names of the metrics (comma separated) to


lmazuel · 2018-03-16T19:20:23Z

azure-mgmt-monitor/azure/mgmt/monitor/operations/metrics_operations.py

        :param aggregation: The list of aggregation types (comma separated) to
         retrieve.
        :type aggregation: str
        :param top: The maximum number of records to retrieve.
         Valid only if $filter is specified.
         Defaults to 10.
-        :type top: float
+        :type top: int


lmazuel · 2018-03-16T19:20:28Z

azure-mgmt-monitor/azure/mgmt/monitor/operations/metrics_operations.py

@@ -74,6 +77,9 @@ def list(
         allowed depends on the operation. See the operation's description for
         details. Possible values include: 'Data', 'Metadata'
        :type result_type: str or ~azure.mgmt.monitor.models.ResultType
+        :param metricnamespace: Metric namespace to query metric definitions


new parameter

lmazuel · 2018-03-16T19:20:42Z

azure-mgmt-monitor/azure/mgmt/monitor/operations/metric_definitions_operations.py

        """Lists the metric definitions for the resource.

        :param resource_uri: The identifier of the resource.
        :type resource_uri: str
+        :param metricnamespace: Metric namespace to query metric definitions


new parameter

lmazuel added the ServicePR label Feb 8, 2018

lmazuel mentioned this pull request Feb 15, 2018

[MgmtMonitor] Added new receivers to action group document. #1752

Closed

AutorestCI mentioned this pull request Feb 16, 2018

Support logicAppReceivers in actionGroup apis Azure/azure-rest-api-specs#2511

Merged

10 tasks

AutorestCI added a commit that referenced this pull request Feb 16, 2018

Rebuild by #1931

e16375f

AutorestCI added the ServicePR label Feb 16, 2018

AutorestCI mentioned this pull request Feb 16, 2018

[DO NOT MERGE, until feb 20] Adding 2018-01-01 version for metrics API Azure/azure-rest-api-specs#2435

Merged

10 tasks

AutorestCI added the ServicePR label Feb 16, 2018

AutorestCI mentioned this pull request Feb 16, 2018

Update monitor Py conf Azure/azure-rest-api-specs#2512

Merged

AutorestCI and others added 6 commits February 28, 2018 18:22

[Monitor] Add Public Preview APIs of Metric Baseline (#1710)

2fc289f

* Generated from e6af07c * Update Monitor version

Generated from df75ee5f47b030dfa0d66e0cac2cf68fcc29b071 (#1891)

a36f114

fix python sdk failure

Generated from 00a5689e14e49f0c822c7e5a9807982ec2ecda45 (#1927)

98c65ea

[Monitor] Make all attributes of EventData class readonly (#2254)

Rebuild by #1931

d017994

Generated from eabf2683eee832655c5e028aa1f3501a6113780b (#2009)

deb50ba

Update monitor Py conf

AutorestCI force-pushed the restapi_auto_monitor/resource-manager branch from 2dd7bbb to d27e72f Compare February 28, 2018 18:22

AutorestCI added the ServicePR label Mar 1, 2018

AutorestCI mentioned this pull request Mar 1, 2018

[Monitor] Fixing issue with metricsnamespace incorrecly specified as client level argument #2565 Azure/azure-rest-api-specs#2566

Merged

10 tasks

Generated from 067e5a9fee3acee4afed33296cadde18b73a3f1c (#2080)

6de6322

[Monitor] Fixing issue with metricnamespace specification as client level argument #2565

AutorestCI mentioned this pull request Mar 2, 2018

[Monitor] Fixing issue with metrics api query parameter name (#2575) Azure/azure-rest-api-specs#2577

Merged

10 tasks

Generated from b0b757a970cf10c190a722bef8a33de12b42ee93 (#2087)

0875231

[Monitor] Fixing issue with metrics api queryparameter name (#2575)

This was referenced Mar 8, 2018

[Monitor] adding metricalerts api specifications Azure/azure-rest-api-specs#2316

Closed

[Monitoring] Add metric alerts api 2018-03-01 Azure/azure-rest-api-specs#2620

Merged

Support azureFunctionReceivers in actionGroup APIs Azure/azure-rest-api-specs#2659

Merged

AutorestCI mentioned this pull request Mar 14, 2018

[Monitor] Fixing incorrect specification of top parameter for Metrics API (#2655) Azure/azure-rest-api-specs#2662

Merged

10 tasks

Generated from 189d112e0d578ff72b4e4531174f8d3c80c0b2f3 (#2176)

18d253a

[Monitor] Fixing incorrect specification of top parameter for Metrics API (#2655)

Generated from a878bd64cf43e5cb9155fdecff440bfee98a49ce (#2174)

9afc4f7

Support azureFunctionReceivers in actionGroup APIs

lmazuel commented Mar 16, 2018

View reviewed changes

lmazuel added 2 commits March 19, 2018 12:47

azure-mgmt-monitor 0.5.0

98dac47

Re-record Monitor tests

b779c2d

lmazuel merged commit 5e33876 into master Mar 19, 2018

lmazuel pushed a commit that referenced this pull request Mar 19, 2018

Rebuild by #1931

b9c56ab

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AutoPr] monitor/resource-manager #1931

[AutoPr] monitor/resource-manager #1931

lmazuel commented Feb 8, 2018

codecov-io commented Feb 8, 2018 •

edited

Loading

lmazuel commented Feb 16, 2018

AutorestCI commented Feb 16, 2018

lmazuel commented Feb 16, 2018

AutorestCI commented Feb 16, 2018

lmazuel commented Feb 28, 2018

AutorestCI commented Feb 28, 2018

AutorestCI commented Mar 14, 2018 •

edited

Loading

lmazuel Mar 16, 2018

lmazuel Mar 16, 2018

lmazuel Mar 16, 2018

lmazuel Mar 16, 2018

lmazuel Mar 16, 2018

lmazuel Mar 16, 2018

lmazuel Mar 16, 2018

lmazuel Mar 16, 2018

lmazuel Mar 16, 2018

[AutoPr] monitor/resource-manager #1931

[AutoPr] monitor/resource-manager #1931

Conversation

lmazuel commented Feb 8, 2018

codecov-io commented Feb 8, 2018 • edited Loading

Codecov Report

lmazuel commented Feb 16, 2018

AutorestCI commented Feb 16, 2018

lmazuel commented Feb 16, 2018

AutorestCI commented Feb 16, 2018

Installation instruction

Package azure-mgmt-monitor

lmazuel commented Feb 28, 2018

AutorestCI commented Feb 28, 2018

AutorestCI commented Mar 14, 2018 • edited Loading

Installation instruction

Package azure-mgmt-monitor

Direct download

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Feb 8, 2018 •

edited

Loading

AutorestCI commented Mar 14, 2018 •

edited

Loading