Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitor] adding metricalerts api specifications #2316

Closed
wants to merge 7 commits into from
Closed

[Monitor] adding metricalerts api specifications #2316

wants to merge 7 commits into from

Conversation

LeoVannelli
Copy link
Contributor

@LeoVannelli LeoVannelli commented Jan 23, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [x ] The title of the PR is clear and informative.
  • [x ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [x ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • [x ] If applicable, the PR references the bug/issue that it fixes.
  • [x ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@olydis
Copy link
Contributor

olydis commented Jan 23, 2018

@LeoVannelli @ravbhatnagar has this gone through the API review board?

@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Jan 23, 2018 via email •
edited by olydis
Loading

@olydis
Copy link
Contributor

olydis commented Jan 23, 2018

@LeoVannelli you're at the right place, just wanted to confirm 🙂

@olydis olydis added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jan 23, 2018
@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Jan 30, 2018 via email

gucalder
gucalder reviewed Feb 1, 2018
View reviewed changes
.../monitor/resource-manager/microsoft.insights/preview/2017-09-01-preview/metricAlert_API.json Outdated
},
"default": {
"description": "BadRequest",
"schema": { "$ref": "#/definitions/CloudError" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this name is the same we use in the other specs. So that our customers know what type will be returned in an error and we do not need to change PowerShell later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeoVannelli if the type is defined in another spec, I'd actually recommend referencing it directly (see here for example syntax).

@AutorestCI
Copy link

AutorestCI commented Feb 9, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: profileBuilder -s list -l ./profiles/2017-03-09/defintion.txt -name 2017-03-09
Finished with return code 1
and output:

Error: unknown command "2017-03-09" for "profileBuilder"
Run 'profileBuilder --help' for usage.
unknown command "2017-03-09" for "profileBuilder"

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

AutorestCI commented Feb 10, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1931

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@olydis
Copy link
Contributor

olydis commented Feb 21, 2018

@LeoVannelli any updates regarding API review?

@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Feb 21, 2018 via email

@olydis
Copy link
Contributor

olydis commented Feb 22, 2018

@LeoVannelli did you see my email regarding the API review board process? Please schedule a meeting with azureapirbcore@microsoft.com (usually somewhere around Monday/Tuesday 2pm-4pm).

@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Feb 22, 2018 via email

@AutorestCI
Copy link

AutorestCI commented Mar 8, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Mar 8, 2018
Closed
@LeoVannelli LeoVannelli closed this Mar 8, 2018
@LeoVannelli
Copy link
Contributor Author

too old starting over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olydis olydis olydis left review comments

@gucalder gucalder gucalder left review comments

Assignees

@olydis olydis

Labels
APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeoVannelli @olydis @AutorestCI @azuresdkciprbot @gucalder