Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Add metric alerts api 2018-03-01 #2620

Merged
merged 19 commits into from
Mar 23, 2018
Merged

[Monitoring] Add metric alerts api 2018-03-01 #2620

merged 19 commits into from
Mar 23, 2018

Conversation

LeoVannelli
Copy link
Contributor

@LeoVannelli LeoVannelli commented Mar 8, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 8, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2541

@AutorestCI AutorestCI mentioned this pull request Mar 8, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 8, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2226

@AutorestCI
Copy link

AutorestCI commented Mar 8, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1413

@AutorestCI AutorestCI mentioned this pull request Mar 13, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 13, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
Azure/azure-libraries-for-java#314

@olydis
Copy link
Contributor

olydis commented Mar 13, 2018

@LeoVannelli this went through the API review board now, correct? 🙂

@olydis olydis added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 13, 2018
@olydis
Copy link
Contributor

olydis commented Mar 13, 2018

@ravbhatnagar new API

@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Mar 13, 2018 via email

@rboucher
Copy link

@rboucher. Please notify me when this PR is accepted. Docs are waiting on it.

@snehithm
Copy link

@ravbhatnagar Can you review this? This is the GA version of metricalerts API. Preview version was already reviewed by you. @LeoVannelli added information above about the deltas.

@lmazuel
Copy link
Member

lmazuel commented Mar 16, 2018

@AutorestCI rebuild azure-sdk-for-python

ravbhatnagar
ravbhatnagar reviewed Mar 16, 2018
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Other than that looks good.

...ification/monitor/resource-manager/microsoft.insights/stable/2018-03-01/metricAlert_API.json
"evaluationFrequency": "PT1M",
"windowSize": "PT15M",
"criteria": {
"odata.type": "Microsoft.Azure.Monitor.SingleResourceMultipleMetricCriteria",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make odata.type as an enum and then set modelAsString to true?

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Mar 16, 2018 •
edited
Loading

Signing off from ARM side. Feel free to merge based on the response to above comment.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 16, 2018
@AutorestCI AutorestCI mentioned this pull request Mar 16, 2018
Closed
@lmazuel
Copy link
Member

lmazuel commented Mar 19, 2018

@AutorestCI regenerate azure-sdk-for-python

@AutorestCI AutorestCI mentioned this pull request Mar 19, 2018
Merged
@olydis
Copy link
Contributor

olydis commented Mar 20, 2018

@LeoVannelli thanks for your response regarding API review board. You mentioned the preview version got "stuck" in review - but what about this version? Has it been reviewed by the board or what is the plan? 🙂

@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Mar 20, 2018 via email

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2018
Merged
@LeoVannelli
Copy link
Contributor Author

Pull request has been updated with review feedback. Review board has approved. Waiting on final review and merge.

@snehithm
Copy link

@olydis Leo had a review and it was signed off in the meeting. Can we get this merged? We are waiting on this merge to go through for us update the docs.

Regards,
Snehith

fearthecowboy
fearthecowboy reviewed Mar 21, 2018
View reviewed changes
...ification/monitor/resource-manager/microsoft.insights/stable/2018-03-01/metricAlert_API.json Outdated
"get": {
"tags": [ "MetricAlertsStatus" ],
"description": "Retrieve an alert rule status.",
"operationId": "MetricAlertsStatus_listByName",
Copy link
Member

@fearthecowboy fearthecowboy Mar 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"operationId": "MetricAlertsStatus_listByName",

Should be

"operationId": "MetricAlertsStatus_ListByName",

fearthecowboy
fearthecowboy reviewed Mar 21, 2018
View reviewed changes
...ification/monitor/resource-manager/microsoft.insights/stable/2018-03-01/metricAlert_API.json Outdated
},
"criteria": {
"$ref": "#/definitions/MetricAlertCriteria",
"description": "criteria"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"description": "criteria" is really vague and it causes a validation error -- can you put in a better description?

@fearthecowboy
Copy link
Member

You have a couple of small typos (mentioned in comments)

and your example data isn't passing validation (see: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/356119129#L733 )

@fearthecowboy fearthecowboy self-assigned this Mar 21, 2018
@fearthecowboy fearthecowboy added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Mar 21, 2018
@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Mar 21, 2018 via email

@LeoVannelli
Copy link
Contributor Author

Updated examples with corrections, not sure if all items are fixed, how can I run the test you executed to validate locally

@fearthecowboy
Copy link
Member

Hey @LeoVannelli

You can run the tests locally by installing autorest and then running:

# start where your readme.md file is.
cd azure-rest-api-specs/specification/monitor/resource-manager

# run the linter rules validation
autorest --azure-validator readme.md

# install the oav tool  (example validation)
npm install -g oav

# run the oav tool 
oav validate-example microsoft.insights/stable/2018-03-01/metricAlert_API.json

@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Mar 22, 2018 via email

RikkiGibson
RikkiGibson reviewed Mar 22, 2018
View reviewed changes
...ification/monitor/resource-manager/microsoft.insights/stable/2018-03-01/metricAlert_API.json Outdated
},
"criteria": {
"$ref": "#/definitions/MetricAlertCriteria",
"description": "definies the specific alert criteria information."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*defines

@LeoVannelli
Copy link
Contributor Author

LeoVannelli commented Mar 22, 2018 via email

@LeoVannelli
Copy link
Contributor Author

Any updates on this? Examples have been fixed just waiting on approval and merge.

@fearthecowboy fearthecowboy removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Mar 23, 2018
@fearthecowboy fearthecowboy merged commit dc201c0 into Azure:master Mar 23, 2018
@AutorestCI AutorestCI mentioned this pull request Mar 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson left review comments

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@fearthecowboy fearthecowboy fearthecowboy approved these changes

@tiffanyachen tiffanyachen Awaiting requested review from tiffanyachen

@vladbarosan vladbarosan Awaiting requested review from vladbarosan

Assignees

@fearthecowboy fearthecowboy

@olydis olydis

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@LeoVannelli @AutorestCI @olydis @rboucher @snehithm @lmazuel @ravbhatnagar @fearthecowboy @RikkiGibson