-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Data Factory] Generate new SDK #5142
Conversation
@@ -61,18 +60,5 @@ public StoredProcedureParameter(object value, string type = default(string)) | |||
[JsonProperty(PropertyName = "type")] | |||
public string Type { get; set; } | |||
|
|||
/// <summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. Needs a major version bump,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! How to do major version bump? Any documents I can refer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the versioning guidelines we follow.
Essentially the Nuget version must be set to 3.0.0
. Please make sure to update the AssemblyInfo.cs
file too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Deepak. Updated to 3.0.0
@meiyan-Li How was this code generated, did you use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from versioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,6 +1,20 @@ | |||
# Changelog for the Azure Data Factory V2 .NET SDK | |||
|
|||
## Current version | |||
## Version 3.0.0 | |||
|
|||
### Feature Additions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the names of activities to be upper case and fix some other casings - Delete activity, Validation activity, Exposure Control API-s, SSIS, WinAuth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meiyan-Li I will fix these once @dsgouda merges this PR.
<AssemblyName>Microsoft.Azure.Management.DataFactory</AssemblyName> | ||
<PackageTags>Microsoft Azure resource management;Data Factory;ADF;</PackageTags> | ||
<PackageReleaseNotes>Taking dependency on 10.0.3 version of Newtonsoft nuget package.</PackageReleaseNotes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the white spaces and fix casing here as well. These notes will be the release notes for the new nuget package.
@dsgouda Can you please merge this PR? I will update the release notes once you merge this so I can start our release. |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.