Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Data Factory] Change Ssis activity property type to support expression #4939

Merged
merged 1 commit into from
Jan 3, 2019
Merged

[Azure Data Factory] Change Ssis activity property type to support expression #4939

merged 1 commit into from
Jan 3, 2019

Conversation

shawncx
Copy link
Contributor

@shawncx shawncx commented Dec 18, 2018

Change type of Ssis actitvity properties from string to object so that we can use expression for these properties
The change include properties:

  1. packagePath of SSISPackageLocation
  2. runtime
  3. loggingLevel
  4. environmentPath

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@msxichen
Change type of Ssis actitvity's packagePath, runtime, loggingLevel and
f9be2a6 
environmentPath from string to object, so that we can use expression for
these properties
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@azuresdkci azuresdkci requested a review from hovsepm December 18, 2018 05:50
@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3798

@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4190

This was referenced Dec 18, 2018
Closed
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#578

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hovsepm hovsepm requested a review from hvermis December 18, 2018 21:43
@hovsepm
Copy link
Contributor

hovsepm commented Dec 18, 2018

@hvermis could you review this PR?

@hovsepm
Copy link
Contributor

hovsepm commented Dec 18, 2018

@shawncx could you sign the CLA?

@hovsepm hovsepm closed this Dec 20, 2018
@hovsepm hovsepm reopened this Dec 20, 2018
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

This was referenced Dec 20, 2018
Merged
Merged
Merged
Merged
@hovsepm hovsepm merged commit 7ca4310 into Azure:master Jan 3, 2019
@kpajdzik kpajdzik removed the review label Jan 3, 2019
@meiyan-Li meiyan-Li mentioned this pull request Jan 15, 2019
Merged
9 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@shawncx @AnuTalluri
Change type of Ssis actitvity's packagePath, runtime, loggingLevel and (
d3b7129 
Azure#4939)

environmentPath from string to object, so that we can use expression for
these properties
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@darkoa-msft
Pulled v3 common types from public main (#4939)
12d6a00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvermis hvermis hvermis approved these changes

@hovsepm hovsepm hovsepm approved these changes

Assignees

@hovsepm hovsepm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shawncx @AutorestCI @azuresdkci @hovsepm @hvermis @kpajdzik @msxichen