Add exposure control APIs according to the ARM compliance requirement. #4958

zhangyd2015 · 2018-12-22T09:55:16Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-portal-comment · 2018-12-22T09:55:17Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

azuresdkci · 2018-12-22T09:55:38Z

Hello!!

The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays!

Thanks and Have a WONDERFUL HOLIDAY

AutorestCI · 2018-12-22T09:55:44Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2018-12-22T09:56:54Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-22T09:56:56Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

zhangyd2015 · 2018-12-22T09:59:00Z

The two APIs are used by exposure control. We are asked to add them into swagger for compliance requirement.

AutorestCI · 2018-12-22T10:00:11Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3865

AutorestCI · 2018-12-22T10:00:34Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2136

AutorestCI · 2018-12-22T10:02:14Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4190

AutorestCI · 2018-12-22T10:17:47Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#578

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

ravbhatnagar

@zhangyd2015 please take a look at the comment. I am not sure if I understand this API.

ravbhatnagar · 2019-01-09T23:44:02Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

@@ -156,6 +156,54 @@
        }
      }
    },
+    "/subscriptions/{subscriptionId}/providers/Microsoft.DataFactory/locations/{locationId}/getFeatureValue": {


What is the usecase for this API? Is it doing something similar to Azure Feature Exposure Control (AFEC)?

@ravbhatnagar ADF doesn't use Azure Feature Exposure Control, instead we have our own implemented in our backend which controls some throttling limits and enabled disabled features for the customer, and this API is allowing the user to query for a specific value.

ravbhatnagar · 2019-01-10T21:05:23Z

Approving from ARM side since its already present on service. Thanks for clarifying @hvermis

zhangyd2015 · 2019-01-15T02:48:29Z

@hovsepm Could you please merge this PR?

hovsepm · 2019-01-15T21:46:23Z

@zhangyd2015 @anuchandy will review and merge it.

anuchandy · 2019-01-16T15:31:37Z

@zhangyd2015 @hvermis - There are couple of model validation errors. They are not introduced in this PR so not a blocker to merge. Please ensure to triage those. I will create an issue.

Azure#4958) * Add exposure control APIs. * Resolve reivew comments * Delete API ExposureControl_GetFeatureBySubscription * Resolve review comments

Add exposure control APIs.

f81ef7f

kpajdzik added the review label Dec 22, 2018

azuresdkci assigned hovsepm Dec 22, 2018

azuresdkci requested a review from hovsepm December 22, 2018 09:56

AutorestCI mentioned this pull request Dec 22, 2018

[AutoPR datafactory/resource-manager] Add exposure control APIs according to the compliance request. Azure/azure-sdk-for-python#4105

Merged

AutorestCI mentioned this pull request Dec 22, 2018

[AutoPR datafactory/resource-manager] Add exposure control APIs according to the compliance request. Azure/azure-sdk-for-go#3777

Closed

AutorestCI mentioned this pull request Dec 22, 2018

[AutoPR datafactory/resource-manager] Add exposure control APIs according to the compliance request. Azure/azure-sdk-for-java#2814

Closed

AutorestCI mentioned this pull request Dec 22, 2018

[AutoPR datafactory/resource-manager] Add exposure control APIs according to the compliance request. Azure/azure-sdk-for-node#4490

Closed

AutorestCI mentioned this pull request Dec 22, 2018

[AutoPR datafactory/resource-manager] Add exposure control APIs according to the compliance request. Azure/azure-sdk-for-js#879

Merged

zhangyd2015 changed the title ~~Add exposure control APIs according to the compliance request.~~ Add exposure control APIs according to the ARM compliance requirement. Dec 22, 2018

hovsepm added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 26, 2018

hovsepm reviewed Dec 26, 2018

View reviewed changes

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Show resolved Hide resolved

hovsepm reviewed Dec 26, 2018

View reviewed changes

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Outdated Show resolved Hide resolved

Resolve reivew comments

741fceb

hvermis requested changes Jan 7, 2019

View reviewed changes

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Outdated Show resolved Hide resolved

Delete API ExposureControl_GetFeatureBySubscription

0c64157

hvermis reviewed Jan 8, 2019

View reviewed changes

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Outdated Show resolved Hide resolved

hvermis approved these changes Jan 8, 2019

View reviewed changes

Resolve review comments

32f235c

ravbhatnagar reviewed Jan 9, 2019

View reviewed changes

ravbhatnagar added the ARMReviewInProgress label Jan 9, 2019

hovsepm removed their assignment Jan 10, 2019

hovsepm added the Reassign label Jan 10, 2019

azuresdkci removed the Reassign label Jan 10, 2019

azuresdkci assigned anuchandy Jan 10, 2019

azuresdkci requested a review from anuchandy January 10, 2019 02:04

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 10, 2019

anuchandy approved these changes Jan 16, 2019

View reviewed changes

anuchandy merged commit b42820a into Azure:master Jan 16, 2019

AutorestCI mentioned this pull request Jan 16, 2019

[AutoPR datafactory/resource-manager] Add exposure control APIs according to the ARM compliance requirement. Azure/azure-sdk-for-go#3888

Merged

meiyan-Li mentioned this pull request Jan 17, 2019

[Azure Data Factory] Generate new SDK Azure/azure-sdk-for-net#5142

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add exposure control APIs according to the ARM compliance requirement. #4958

Add exposure control APIs according to the ARM compliance requirement. #4958

zhangyd2015 commented Dec 22, 2018

openapi-portal-comment bot commented Dec 22, 2018

azuresdkci commented Dec 22, 2018

AutorestCI commented Dec 22, 2018 •

edited

Loading

azuresdkci commented Dec 22, 2018

AutorestCI commented Dec 22, 2018 •

edited

Loading

zhangyd2015 commented Dec 22, 2018

AutorestCI commented Dec 22, 2018 •

edited

Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

ravbhatnagar left a comment

ravbhatnagar Jan 9, 2019

hvermis Jan 9, 2019

ravbhatnagar commented Jan 10, 2019

zhangyd2015 commented Jan 15, 2019

hovsepm commented Jan 15, 2019

anuchandy commented Jan 16, 2019 •

edited

Loading

Add exposure control APIs according to the ARM compliance requirement. #4958

Add exposure control APIs according to the ARM compliance requirement. #4958

Conversation

zhangyd2015 commented Dec 22, 2018

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Dec 22, 2018

azuresdkci commented Dec 22, 2018

AutorestCI commented Dec 22, 2018 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Dec 22, 2018

AutorestCI commented Dec 22, 2018 • edited Loading

Automation for azure-sdk-for-python

zhangyd2015 commented Dec 22, 2018

AutorestCI commented Dec 22, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Dec 22, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Dec 22, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Dec 22, 2018 • edited Loading

Automation for azure-sdk-for-js

ravbhatnagar left a comment

Choose a reason for hiding this comment

ravbhatnagar Jan 9, 2019

Choose a reason for hiding this comment

hvermis Jan 9, 2019

Choose a reason for hiding this comment

ravbhatnagar commented Jan 10, 2019

zhangyd2015 commented Jan 15, 2019

hovsepm commented Jan 15, 2019

anuchandy commented Jan 16, 2019 • edited Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

AutorestCI commented Dec 22, 2018 •

edited

Loading

anuchandy commented Jan 16, 2019 •

edited

Loading