Modify logic of deploying Arm template according to artifacts #18773
Conversation
|
/azp run java - spring - tests |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yiliuTo
requested review from
danieljurek,
JimSuplizio,
mitchdenny and
weshaggard
as code owners
| This script searches the directory specified in $ServiceDirectory recursively | ||
| for files named test-resources.json. | ||
| This script searches for files named test-resources.json in each artifact project | ||
| of $Artifacts under $ServiceDirectory recursively. When $Artifacts is not set, the |
There was a problem hiding this comment.
Sometimes directory name not equal to artifact name.
So maybe we can use SubDirectories instead of Artifacts?
| @@ -550,6 +567,11 @@ A directory under 'sdk' in the repository root - optionally with subdirectories | |||
| specified - in which to discover ARM templates named 'test-resources.json'. | |||
| This can also be an absolute path or specify parent directories. | |||
|
|
|||
| .PARAMETER Artifacts | |||
| A string of all artifact names defined in tests.yml under ServiceDirectory. If the | |||
There was a problem hiding this comment.
To keep same style, use Artifact instead of artifact
| .PARAMETER Artifacts | ||
| A string of all artifact names defined in tests.yml under ServiceDirectory. If the | ||
| value is not set, then all ARM templates under ServiceDirectory will be found to deploy | ||
| test resources. Otherwise, only templates under ServiceDirectory/artifact will be discovered. |
| @@ -21,6 +21,9 @@ param ( | |||
| [Parameter(Mandatory = $true, Position = 0)] | |||
| [string] $ServiceDirectory, | |||
|
|
|||
| [Parameter()] | |||
There was a problem hiding this comment.
cc @benbp
You cannot edit these common files in the language repo instead you need to follow the https://github.com/Azure/azure-sdk-tools/blob/master/doc/common/common_engsys.md#workflow
There was a problem hiding this comment.
Thanks @weshaggard , I will follow the workflow and work with @benbp .
There was a problem hiding this comment.
Please work with @benbp to come up with a design for this change and lets make the changes under eng/common in the azure-sdk-tools repo.
|
@yiliuTo I'll chat with you offline and we can put our design notes here. |
Update compute.json (Azure#18773)
This PR modifies the logic of deploying Arm template for Live tests.
The original method is to scan all test-resources.json files under the directory of $ServiceDirectory, however, for the Spring live tests in Azure China Cloud, we only want to run parts of tests which don't need to deploy any test resources, and can be refered here: #18774.
Thus we want to modify the logic as scanning test-resources.json in each provided artifact project under $ServiceDirectory, here the artifact parameter is passed from each tests.yml.
And if no artifact is provided, then the script will follow its original logic that scan all test-resources.json files under $ServiceDirectory recursively.