Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[live tests] test-resources.* file location and test parenting should be more flexible #2050

Closed
benbp opened this issue Nov 20, 2020 · 6 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@benbp
Copy link
Member

benbp commented Nov 20, 2020

Currently the test-resources.json, test-resources-pre.ps1 and test-resources-post.ps1 files are mapped 1:1 with all tests located within a service directory, and must be located within sdk/<service>/test-resources.*. This 1:1 mapping makes it harder to split up resource generation on a more granular basis, such as when there are multiple services per sdk (as is the case with storage, e.g. blob, batch, datalake, etc.).

We should perhaps support something like parameterized test-resources file locations or some sort of directory walking (look for files in sdk/<service>/<sub-service>/* first. Basically a way to better map resource provisioning to tests per-sdk, when they all exist within one pipeline definition.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 20, 2020
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Nov 20, 2020
@kurtzeborn kurtzeborn removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 24, 2020
@heaths
Copy link
Member

heaths commented Jan 26, 2021

Supporting nested file paths - much like git and other common file patterns - would be pretty easy to support. Start deep and work up, just like .gitignore files.

@heaths
Copy link
Member

heaths commented Jan 26, 2021

Another idea that was discussed was first deploy the general service template then, depending on its outputs, you could also go deeper. IMO, if there's no great reason to, not only would this take more time than a combined ARM template set, but would be more confusion for devs to use or probably us to support.

@benbp
Copy link
Member Author

benbp commented Jan 27, 2021

Related: Azure/azure-sdk-for-java#18773

@benbp
Copy link
Member Author

benbp commented Jan 27, 2021

@heaths I like the nested path, working up model. ServiceDirectory can already contain multiple directories (e.g. identity/some-sub-service) based on my reading of the code, but adding logic to search up to the base URI segment of the value could eliminate the need for manually specifying the service directory across all repos where there may be nested templates or not.

@heaths
Copy link
Member

heaths commented Jan 28, 2021

Yeah - the subdir resolution was intentional because, at one point in my design, the idea was to support sub-services (but not merging - which I like the idea of we're discussing here).

Copy link

Hi @benbp, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

No branches or pull requests

4 participants