-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TestResourceDirectories parameter to store Arm template paths #18851
Conversation
/azp run java - spring - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - spring - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - spring - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me but I will defer to @benbp
@weshaggard yep this is the direction we chatted about. It's nice because it doesn't require any underlying eng/common changes. |
Hi @weshaggard and @benbp , now that Ben and I have come to an agreement of this PR, can we get it approved? |
…into deploy-arm-template-flexibly
@yiliuTo I still had one comment otherwise looks good |
…into deploy-arm-template-flexibly
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
/azp run java - spring - tests |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run java - spring - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - spring - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - spring - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/check-enforcer override |
[Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2022-05-01 (Azure#18851) * Adds base for updating Microsoft.AzureStackHCI from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * added patch API to ArcSettings resource and introduced ArcConnectivityProperties attribute * fixing formatting issue * adding 202 into delete example * prettier formatting fix * addressing code review comments
This PR modifies the logic of deploying Arm template for Live tests and is migrated from #18773.
The original method is to scan all test-resources.json files under the directory of
$ServiceDirectory
, however, we want to provide a flexible way to split up Arm templates to be deployed.This PR add a new sequence parameter of
$TestResourceDirectories
in archetype-sdk-tests.yml to specify directories of test-resources.json that is expected to be deployed.