Grlin/Adding Principal Type to RA

[grlin]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3262

[AutorestCI]

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1619

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3486

[AutorestCI]

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2361

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2613

[anuchandy]

@annatisch is it ok if i take this PR? I'm working with @grlin already on this.

[annatisch]

Thanks @anuchandy! :)

[anuchandy]

Is there a list of known values for principal types?

[grlin]

Yes, there is. Where should I include this?

[anuchandy]

you can define it as an openapi enum type, like

        "principalType": {
          "type": "string",
          "description": "The principal type of the assigned principal ID, e.g. user, service principal",
          "enum": [
            "User",
            "<other-value1>",
            "<other-value2>"
          ],
          "x-ms-enum": {
            "name": "PrincipalType",
            "modelAsString": true|false
          }
        }

List all the possible values under principalType::enum array.

If this list is limited and not going to change at least in this api-version then use "modelAsString":false otherwise "modelAsString": true.

Also is this a readonly property? then you can mark it as readonly: true as well.

[grlin]

How can I update this PR?

[grlin]

I've pushed the commit