Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grlin/principal type bypassfor ra #4910

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

grlin
Copy link
Contributor

@grlin grlin commented Oct 22, 2018

Description

Azure/azure-rest-api-specs#3737


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was the code generated? Please commit the changes to .txt file

@dsgouda
Copy link
Contributor

dsgouda commented Oct 22, 2018

Please fix the CI failures

@dsgouda
Copy link
Contributor

dsgouda commented Oct 23, 2018

@grlin Please link the related REST spec PR and squash all commits into one, we should be good to merge

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit e2eb185 into Azure:psSdkJson6 Oct 23, 2018
v-djnisi pushed a commit to v-djnisi/azure-sdk-for-net that referenced this pull request Oct 30, 2018
ahamad-MS pushed a commit to ahamad-MS/azure-sdk-for-net that referenced this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants