-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding principal type to RA Create Parameters #3717
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-rubyA PR has been created for you: |
Can one of the admins verify this patch? |
"parameters": { | ||
"scope": "scope", | ||
"roleId": "roleAssignmentId", | ||
"api-version": "2018-01-01-preview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change the api versions for all the examples
- Microsoft.Authorization/preview/2015-06-01/authorization-ClassicAdminCalls.json | ||
- Microsoft.Authorization/preview/2018-09-01-preview/authorization-RoleBasedCalls.json | ||
``` | ||
|
||
--- | ||
# Code Generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tag for GO like this
Tag: package-2018-01-01-preview and go
These settings apply only when --tag=package-2018-01-01-preview --go
is specified on he command line.
Please also specify --go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>
.
output-folder: $(go-sdk-folder)/services/authorization/mgmt/2018-01-01-preview/authorization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this is only done for go and not Java etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure
- Microsoft.Authorization/preview/2015-06-01/authorization-ClassicAdminCalls.json | ||
- Microsoft.Authorization/preview/2018-09-01-preview/authorization-RoleBasedCalls.json | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include your api version in GO multi api version
Go multi-api
batch:
- tag: package-2015-07
- tag: package-2017-10-01-preview
- tag: package-2018-01-01-preview
Automation for azure-sdk-for-javaA PR has been created for you: |
Automation for azure-sdk-for-goA PR has been created for you: |
Looks good from my side |
Closing this in-favor of #3737 |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger