Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding principal type to RA Create Parameters #3717

Closed
wants to merge 2 commits into from
Closed

Conversation

grlin
Copy link
Contributor

@grlin grlin commented Aug 24, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 24, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3193

@grlin
Copy link
Contributor Author

grlin commented Aug 24, 2018

@darshanhs90

@AutorestCI
Copy link

AutorestCI commented Aug 24, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3417

@AutorestCI
Copy link

AutorestCI commented Aug 24, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1597

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

"parameters": {
"scope": "scope",
"roleId": "roleAssignmentId",
"api-version": "2018-01-01-preview"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you change the api versions for all the examples

- Microsoft.Authorization/preview/2015-06-01/authorization-ClassicAdminCalls.json
- Microsoft.Authorization/preview/2018-09-01-preview/authorization-RoleBasedCalls.json
```

---
# Code Generation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tag for GO like this

Tag: package-2018-01-01-preview and go

These settings apply only when --tag=package-2018-01-01-preview --go is specified on he command line.
Please also specify --go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>.

output-folder: $(go-sdk-folder)/services/authorization/mgmt/2018-01-01-preview/authorization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is only done for go and not Java etc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure

- Microsoft.Authorization/preview/2015-06-01/authorization-ClassicAdminCalls.json
- Microsoft.Authorization/preview/2018-09-01-preview/authorization-RoleBasedCalls.json
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include your api version in GO multi api version

Go multi-api

batch:
  - tag: package-2015-07
  - tag: package-2017-10-01-preview
  - tag: package-2018-01-01-preview

@AutorestCI
Copy link

AutorestCI commented Aug 24, 2018

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2345

@AutorestCI
Copy link

AutorestCI commented Aug 24, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2537

@darshanhs90
Copy link
Contributor

Looks good from my side

@anuchandy
Copy link
Member

Closing this in-favor of #3737

@anuchandy anuchandy closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants