Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the deprecated classic alerts spec #30785

Conversation

grchris-microsoft
Copy link
Contributor

@grchris-microsoft grchris-microsoft commented Sep 29, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

wangbwn and others added 30 commits August 21, 2024 14:46
Co-authored-by: Bo Wang <v-bw@microsoft.com>
Co-authored-by: Jingshu918 <138486531+Jingshu918@users.noreply.github.com>
….hardware security modules 2024-06-30-preview (Azure#29712)

* Copy files from preview/2023-12-10-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-06-30-preview

Updated the API version from preview/2023-12-10-preview to preview/2024-06-30-preview.

* Added tag for 2024-06-30-preview in readme file

* Create new updates

* update examples

* update

* update

* run prettier on examples

* update

* updaates

* update headers for backup restore get APIS

* updates for ARM feedback

* update

* update to resolve BodyTopLevelProperties issue

* fix nesting issues

* update description

* adding required for backupid in backuprequest
* Copy files from stable/2024-02-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-07-01

Updated the API version from stable/2024-02-01 to stable/2024-07-01.

* Added tag for 2024-07-01 in readme file

* 2024-07-01 updates

* Update with NetworkSecurityPerimeter

* Fix errors and remove cloudserviceskus

* Replace cloudserviceconfig with vmconfig in examples

* Prettier fixes

* Prettier fixes

* Final prettier fix

* Create sdk-suppressions.yaml

* Update sdk-suppressions.yaml

* update sdk-suppressions.yaml

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: Alancere <804873052@qq.com>
* 2024 new api version

* fix avocado errors

* add double nested properties to spec

* go back to 2023 version for testing

* fix dates, 2023 structure in 2024

* change spec to nested and examples to nested

* fix prettier

* add PR template and prior version for comparison

* undo changes

* fix prettier

* fix prettier part 2

* diff

* Revert "diff"

This reverts commit 60b9005.

* diff

* final

* Create sdk-suppressions.yaml

* update sdk-suppressions.yaml

* Update sdk-suppressions.yaml

* Update sdk-suppressions.yaml

---------

Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: Alancere <804873052@qq.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
…e#29950)

* move

* operations

* prettier and model

* prettier

* new api version

* api versioning

* operations

* prettier
* Remove duplicate property

Remove duplicate property

* Update types.json

* Update types.json
* Adding new ALI api version

* Fixing format issues

* Correcting example

* Suppress swagger readonly error

* Added version to config in readme

* Correcting suppression

* Updating suppress statement

* Trying a broad definition to suppress

* Testing new level of suppressions

* Added every readonly property to list of suppressions

* Added suppression category in readme.md

* Corrected suppressions

* Adding every readonly property...

* Adding resources to suppression for readonly

* Trying to suppress common type readonly warnings...

* Updated suppression, got rid of where clause

* Added missing example

* Added missing example, recompiled

* Adding Swagger lintDiff suppressions

* Renamed storage billing property sku to azurelargestorageinstancesize

* Revert "Renamed storage billing property sku to azurelargestorageinstancesize"

This reverts commit 59d3e2d.

* Fixing suppression errors

* Fixing examples

* WIP

* Updated put return codes and added msi identity for patch storage

* Updating readme

* Fixing patch

* Corrected create to sync

* Updating examples

* Fixing models

* Updated tspconfig.yaml emit-common-types-schema from never to for-visibility-changes

* Removing emitter from tspconfig.yaml

* Updating readme

* Updating readme to exclude current api version from suppression

---------

Co-authored-by: Ashwin Jeyaseelan <ashwinjeyaseelan@ashwins-mbp4.mynetworksettings.com>
* Allow a Set command for HybridKubernetes.

* prettier linting.

---------

Co-authored-by: Paul D.Smith <pauldsmith@microsoft.com>
* Add 2024-07-01-preview api

* Remove old api version to fix validation

* Fix model validation

* Fix validation

* Update

* Add suppression
* Add client tsp for AzureFleet

* update

* Update examples with valid url to fix model validation failures

* Create sdk-suppressions.yaml

* update sdk-suppressions.yaml

---------

Co-authored-by: Sahil Arora <arorasahil@microsoft.com>
Co-authored-by: Wei Hu <live1206@gmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Alancere <804873052@qq.com>
…-mgmt-rdbms" for Python SDK (Azure#30104)

* python config

* Update readme.python.md
* Copy files from stable/2023-03-15

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-12-01

Updated the API version from stable/2023-03-15 to stable/2024-12-01.

* Added tag for 2024-12-01 in readme file

* Fix Prettier issue
…pend APIs (Azure#30253)

* .

* fix typo

* add suppresions.yaml

* add suppressions to readme.md
)

* fix: Fix enum in 2024-08-15-preview

* tsv

* QoS 2 not supported

* Kafka host value should be required

* MQTT host should be nullable

* generate updates to schema

---------

Co-authored-by: John Lian <jlian@users.noreply.github.com>
* add new tilesetid and fix tilesetid related typo

* add new tilesetid to static image 20240401

* add pin limit to doc

* typo fix

* fix typo

* typo fix for microsoft.imagery

* remove new tilesetid

* fix link
* 2024-09-01 API Changes

* Update detection model recommendation (Azure#30272)

* Adding Stable version for Operations and Readme file changes

* add sdk-suppressions.yaml

* remove supression to check errors

* Revert "remove supression to check errors"

This reverts commit 1475d61.

---------

Co-authored-by: Jaskirat Singh <jasksingh@microsoft.com>
Co-authored-by: Han Chiang <han.chiang@microsoft.com>
Co-authored-by: Alancere <804873052@qq.com>
* update python config

* update python config

* Update readme.python.md
* update python config

* Update readme.python.md
* Update readme.python.md

* Update readme.python.md
@heaths
Copy link
Member

heaths commented Sep 30, 2024

This is impossible to review:

image

Please rebase your commits on main and force push to this PR. Assuming your fork is origin and this repo is upstream:

git fetch upstream main
git checkout grchris-microsoft/remove_classic_alerts_specs # assuming it's not checked out already
git rebase upstream/main
git push --force

@grchris-microsoft
Copy link
Contributor Author

grchris-microsoft commented Sep 30, 2024 via email

@heaths heaths closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.