Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2024-08-01 api-version for Ms.Resources for data boundaries #29950

Merged

Conversation

skadhiresan
Copy link
Contributor

@skadhiresan skadhiresan commented Jul 24, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Jul 24, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Jul 24, 2024

Generated ApiView

Language Package Name ApiView Link
Java azure-resourcemanager-resources-generated https://apiview.dev/Assemblies/Review/69d90a3c09dd41d388271d10f46fbed8?revisionId=1826849a761a48958a87e9983be6a1c7
.Net Azure.ResourceManager.Resources There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armchanges There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armdeploymentscripts https://apiview.dev/Assemblies/Review/7baaae1d269a4ed7912f863425ad71a0?revisionId=e25adf06a01449c8b13108784c40369e
Go sdk/resourcemanager/resources/armdeploymentstacks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armfeatures There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlinks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlocks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armmanagedapplications There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armpolicy https://apiview.dev/Assemblies/Review/307c195eccc840d1b92e75be6564ba10?revisionId=792dce84021a4511a6c72f6cbc0377e9
Go sdk/resourcemanager/resources/armresources https://apiview.dev/Assemblies/Review/12843540e3a1467ea73d364496b55308?revisionId=b16e0f3d44ca40e5a4df49ed7c3e0432
Go sdk/resourcemanager/resources/armsubscriptions There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armtemplatespecs There is no API change compared with the previous version
JavaScript @azure/arm-changes https://apiview.dev/Assemblies/Review/357d9a1c28c440e8a1bd4912e73149e7?revisionId=84609f7321874e42bbc049d59e88e45b
JavaScript @azure/arm-features https://apiview.dev/Assemblies/Review/cdac4d1c1fa1462bb53e5df0b43b1fd8?revisionId=76f22bd0510743f3a3f3b6f72ca1bd5f
JavaScript @azure/arm-links https://apiview.dev/Assemblies/Review/fab6f39d3aa4438bbcf44202497c232d?revisionId=26a1b7e44f544063820710bfc1142cf5
JavaScript @azure/arm-locks https://apiview.dev/Assemblies/Review/5032ea8e14d64cd0adc264676495aba7?revisionId=fff19989964042cbbf64594056945a9d
JavaScript @azure/arm-managedapplications https://apiview.dev/Assemblies/Review/13cbf64f04e64947ba72af718bdd91bf?revisionId=a91dfd160e8a4e9db4654ae0a78117bb
JavaScript @azure/arm-policy https://apiview.dev/Assemblies/Review/cda5950570364aba98f6c682240aed30?revisionId=428dff7b35e0496899406823f2197cd1
JavaScript @azure/arm-resources-subscriptions There is no API change compared with the previous version
JavaScript @azure/arm-resources https://apiview.dev/Assemblies/Review/2afa29187fb74b96ba17874edd55e007?revisionId=be17727e29bd49e7bad3e6b4c252d02b
JavaScript @azure/arm-resourcesdeploymentstacks There is no API change compared with the previous version
JavaScript @azure/arm-templatespecs https://apiview.dev/Assemblies/Review/fc04625bf7df4e6e97f03f7aae3c05b7?revisionId=35d6845a1ab1428d9f00d5c4d88ec841
Swagger Microsoft.Resources https://apiview.dev/Assemblies/Review/c6d5ee6adb604c8d98405cc2ea6c8f31?revisionId=cedd801534f644328cc47618269849d7

@skadhiresan
Copy link
Contributor Author

skadhiresan commented Jul 24, 2024

https://github.com/Azure/azure-rest-api-specs-pr/pull/16798 - refer to this pr for approvals and convos

@skadhiresan
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview NotReadyForARMReview resource-manager SuppressionReviewRequired VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Jul 24, 2024
This was referenced Jul 24, 2024
Copy link

openapi-pipeline-app bot commented Jul 24, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@AzureRestAPISpecReview AzureRestAPISpecReview added new-api-version WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Aug 6, 2024
@skadhiresan skadhiresan changed the title add 2024-03-01 api-version for Ms.Resources for data boundaries add 2024-08-01 api-version for Ms.Resources for data boundaries Aug 7, 2024
@haitch
Copy link
Member

haitch commented Aug 7, 2024

thanks for this, AKS and Azure Policy have feature work depend on this.

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 8, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 8, 2024
@rkmanda rkmanda added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Approved-Suppression and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 8, 2024
@skadhiresan skadhiresan added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 15, 2024
@skadhiresan skadhiresan removed the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 16, 2024
@skadhiresan skadhiresan added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 22, 2024
@skadhiresan skadhiresan merged commit a6074b7 into main Aug 22, 2024
27 of 30 checks passed
@skadhiresan skadhiresan deleted the add-2024-03-api-version-for-Ms.Resources-for-dataBoundaries branch August 22, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants