Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java mgmt, mitigate machine learning services 2024-04 breaking change #30280

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Aug 21, 2024

Still exists breaking changes:

Breaking Changes

  • models.AmlOperation was removed

  • models.AmlOperationListResult was removed

  • models.AmlOperationDisplay was removed

Above is due to service adopting OperationList from common-types:
5fb8294#diff-0a9c1187fadf714a9d2da1e96c508114de48a1662bff03ec9224edd0b9db4ba8

models.CodeVersions was modified

  • list(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.Integer,java.lang.String,com.azure.core.util.Context) was removed

Above due to service adding an optional parameter to the list operation. Not a breaking change for API, though a breaking change for us.

models.ComputeStartStopSchedule was modified

  • models.TriggerType triggerType() -> models.ComputeTriggerType triggerType()
  • models.RecurrenceTrigger recurrence() -> models.Recurrence recurrence()
  • models.CronTrigger cron() -> models.Cron cron()
  • withTriggerType(models.TriggerType) was removed
  • withRecurrence(models.RecurrenceTrigger) was removed
  • withCron(models.CronTrigger) was removed

Above due to complete change of models(rename won't help): 4ede5fd

models.Workspaces was modified

  • delete(java.lang.String,java.lang.String,com.azure.core.util.Context) was removed
  • deleteByResourceGroup(java.lang.String,java.lang.String) was removed
  • deleteByIdWithResponse(java.lang.String,com.azure.core.util.Context) was removed

Above due to newly added optional parameter.

models.PrivateEndpoint was modified

  • subnetArmId() was removed

Above due to service removing this property: 700191d

models.Jobs was modified

  • list(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,models.ListViewType,com.azure.core.util.Context) was removed

Above due to adding optional parameter to list. 7af038c

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Aug 21, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Aug 21, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/machinelearning/armmachinelearning https://apiview.dev/Assemblies/Review/c19328b4fc084461adfa498aa764be2f?revisionId=99d10d3bb36840f4adf743576ac76cf8
Java azure-resourcemanager-machinelearning https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=f66beba248874fe4b812c5e28b3cd80d

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can choose either bump the major version, or suppress it.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 22, 2024
@XiaofeiCao XiaofeiCao added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2024
@XiaofeiCao XiaofeiCao added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Aug 22, 2024
@XiaofeiCao
Copy link
Contributor Author

We can choose either bump the major version, or suppress it.

I don't have strong opinion on this. There's no major fluent layer change after resource association, guess we'll suppress it.

No other sdk's referencing this lib. I think we could just skip revapi.

@XiaofeiCao XiaofeiCao merged commit dec7fb6 into Azure:main Aug 22, 2024
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants