Fixed operationIds for non-CRUD operations in ExpressRouteCrossConnections #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-goA PR has been created for you: |
|
Hi Any reason to do the changes to the operation IDs? |
|
@salameer that is needed to save common style in express routes commands and make this code generatabe for PS. I wait for Vinaya to approve |
|
@MikhailTryakhov please note that this is against the patterns for operationIds ARM recommends |
|
@dsgouda but such style for operation naming is already approved to top-level resource... Our idea was to save similar naming for this set of commands... |
vinayada1
reviewed
Mar 21, 2018
| @@ -478,7 +478,7 @@ | |||
| "tags": [ | |||
| "ExpressRouteCrossConnectionArpTable" | |||
| ], | |||
| "operationId": "ExpressRouteCircuitsArpTable_List", | |||
| "operationId": "ExpressRouteCrossConnections_ListArpTable", | |||
| "description": "Gets the currently advertised ARP table associated with the express route circuit in a resource group.", | |||
There was a problem hiding this comment.
We missed this....could you rename express route circuit in the description to express route cross connection?
vinayada1
approved these changes
Mar 21, 2018
dsgouda
approved these changes
Mar 21, 2018
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-libraries-for-javaA PR has been created for you: |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
|
Addressed @vinayada1's comment |
dsgouda
pushed a commit
that referenced
this pull request
Mar 23, 2018
… 2018 (#2642) * Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API (#2358) * copy all files from 2018-01-01 to 2018-02-01 * update api version to 2018 in all files * add express route circuit connection as child of express route bgp peering * update readme.md * add examples * fix travis build error * fix travis build error * fix indentation errors * update reference to circuit connections in peering * fix indentation * Merge Express Route Circuit Connection to Networking2018-02-01 (#2370) * copy all files from 2018-01-01 to 2018-02-01 * update api version to 2018 in all files * add express route circuit connection as child of express route bgp peering * update readme.md * add examples * fix travis build error * fix travis build error * fix indentation errors * update reference to circuit connections in peering * fix indentation * fix indentation * fix indentation' * get latest file * Fix indentation * fix key * fix indentation and example * fix indentation * fix indentation * make circuit con singular * add fix as PR #2364 (#2376) * Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. (#2521) * 1443089: Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. * 1443089:Fix network ReadMe file. * 1443089:Fix network ReadMe file. * Temporary bug fix * Add support for Express Route Provider APIs (#2532) * Add support for Express Route Provider APIs A new top level NRP resource ExpressRouteCrossConnection is being introduced with this change. This resource shadows the customer ExpressRouteCircuit resouce in the customer subscription and enables the provider to perform CRUD operations on some of the sub-resources, such as peerings on the ExpressRoute Circuit * remove wrong enum values from circuit connection status and fix enum … (#2572) * remove wrong enum values from circuit connection status and fix enum name * Update ExpressRouteCrossConnection Route Table Summary Record (#2574) * Update CrossConnection Route Table Summary record * [Network-2018-02-01] DDoS Protection Plan resource (#2567) * Initial version * Add eol * Add extra property in example * Add default values for fields * Rename operation IDs * Make 'id' read-only for all network resources * Revert "Make 'id' read-only for all network resources" * Fix reference * making peer express route circuit peering and express route circuit peering as references (#2696) * Express Route Cross Connection Swagger changes as per PM requirements (#2644) * Fixed operationIds for non-CRUD operations in ExpressRouteCrossConnections (#2720) * Making travis run > 10 mins (#2739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors ExpressRouteCircuit's non-CRUD operations
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger