Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Express Route Circuit Connection to Networking2018-02-01 #2370

Merged
merged 20 commits into from
Jan 30, 2018
Merged

Merge Express Route Circuit Connection to Networking2018-02-01 #2370

merged 20 commits into from
Jan 30, 2018

Conversation

dedhar
Copy link
Contributor

@dedhar dedhar commented Jan 30, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@dedhar dedhar merged commit 0f85d45 into Azure:Network-2018-02-01 Jan 30, 2018
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

dsgouda pushed a commit that referenced this pull request Mar 23, 2018
@dedhar @dsgouda
Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb…
682e15a 
… 2018 (#2642)

* Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API (#2358)

* copy all files from 2018-01-01 to 2018-02-01

* update api version to 2018 in all files

* add express route circuit connection as child of express route bgp peering

* update readme.md

* add examples

* fix travis build error

* fix travis build error

* fix indentation errors

* update reference to circuit connections in peering

* fix indentation

* Merge Express Route Circuit Connection to Networking2018-02-01 (#2370)

* copy all files from 2018-01-01 to 2018-02-01

* update api version to 2018 in all files

* add express route circuit connection as child of express route bgp peering

* update readme.md

* add examples

* fix travis build error

* fix travis build error

* fix indentation errors

* update reference to circuit connections in peering

* fix indentation

* fix indentation

* fix indentation'

* get latest file

* Fix indentation

* fix key

* fix indentation and example

* fix indentation

* fix indentation

* make circuit con singular

* add fix as PR #2364 (#2376)

* Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. (#2521)

* 1443089: Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients.

* 1443089:Fix network ReadMe file.

* 1443089:Fix network ReadMe file.

* Temporary bug fix

* Add support for Express Route Provider APIs (#2532)

* Add support for Express Route Provider APIs

A new top level NRP resource ExpressRouteCrossConnection is being
introduced with this change. This resource shadows the customer
ExpressRouteCircuit resouce in the customer subscription and enables
the     provider to perform CRUD operations on some of the
sub-resources, such as peerings on the ExpressRoute Circuit

* remove wrong enum values from circuit connection status and fix enum … (#2572)

* remove wrong enum values from circuit connection status and fix enum name

* Update ExpressRouteCrossConnection Route Table Summary Record (#2574)

* Update CrossConnection Route Table Summary record

* [Network-2018-02-01] DDoS Protection Plan resource (#2567)

* Initial version

* Add eol

* Add extra property in example

* Add default values for fields

* Rename operation IDs

* Make 'id' read-only for all network resources

* Revert "Make 'id' read-only for all network resources"

* Fix reference

* making peer express route circuit peering and express route circuit peering as references (#2696)

* Express Route Cross Connection Swagger changes as per PM requirements (#2644)

* Fixed operationIds for non-CRUD operations in ExpressRouteCrossConnections (#2720)

* Making travis run > 10 mins (#2739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda Awaiting requested review from dsgouda

@marstr marstr Awaiting requested review from marstr

@DeepakRajendranMsft DeepakRajendranMsft Awaiting requested review from DeepakRajendranMsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dedhar @AutorestCI @azuresdkciprbot