Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API #2358

dedhar · 2018-01-29T22:21:28Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ering

AutorestCI · 2018-01-29T23:17:49Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-29T23:29:32Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

dedhar · 2018-01-29T23:45:25Z

Relevant Tracking WorkItem : https://msazure.visualstudio.com/One/_queries?id=1715515&triage=false&_a=edit

AutorestCI · 2018-01-29T23:45:39Z

Did a commit to Azure/azure-sdk-for-go:
Azure/azure-sdk-for-go@caeae5c

AutorestCI · 2018-01-29T23:56:34Z

Did a commit to Azure/azure-sdk-for-python:
Azure/azure-sdk-for-python@caba431

dsgouda

Please fix indentations. left a few minor comments. Overall looks good.

dsgouda · 2018-01-30T00:03:07Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-02-01/expressRouteCircuit.json

+            "type": "string",
+            "description": "The name of the peering."
+          },
+		  {


nit: indentation

dsgouda · 2018-01-30T00:04:02Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-02-01/expressRouteCircuit.json

+            "type": "string",
+            "description": "The name of the peering."
+          },
+		  {


nit: indentation

dsgouda · 2018-01-30T00:04:21Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-02-01/expressRouteCircuit.json

+            "description": "The name of the express route circuit connection."
+          },
+          {
+            "name": "expressroutecircuitconnectionParameters",


Please use camel casing here

dsgouda · 2018-01-30T00:04:36Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-02-01/expressRouteCircuit.json

@@ -1219,6 +1394,13 @@
        "ipv6PeeringConfig": {
          "$ref": "#/definitions/Ipv6ExpressRouteCircuitPeeringConfig",
          "description": "The IPv6 peering configuration."
+        },
+		"connections": {


nit: indentation

dsgouda · 2018-01-30T00:04:47Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-02-01/expressRouteCircuit.json

@@ -1260,6 +1442,78 @@
        }
      },
      "description": "Response for ListPeering API service call retrieves all peerings that belong to an ExpressRouteCircuit."
+    },
+	"ExpressRouteCircuitConnectionsPropertiesFormat": {


nit: indentation

dsgouda · 2018-01-30T00:05:36Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-02-01/expressRouteCircuit.json

+          },
+          "description": "The Express Route Circuit Connections in an ExpressRoute Circuit Private Peering."
+        },
+        "nextLink": {


mark this as readonly

removed that item since we are not supporting list operation on circuit connection as of yet

dsgouda · 2018-01-30T00:07:23Z

@DeepakRajendranMsft since this is a new api version PTAL

@dsgouda LGTM

AutorestCI · 2018-01-30T00:27:00Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-30T00:27:41Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

azuresdkciprbot · 2018-01-30T00:50:06Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-01-30T00:57:55Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-30T00:58:41Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

azuresdkciprbot · 2018-01-30T01:16:32Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-01-30T01:18:28Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-30T01:23:49Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-30T01:49:47Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

AutorestCI · 2018-01-30T01:58:18Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-30T02:27:28Z

This commit was treated and no generation was made for Azure/azure-sdk-for-python

AutorestCI · 2018-01-30T02:32:29Z

This commit was treated and no generation was made for Azure/azure-sdk-for-go

… 2018 (#2642) * Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API (#2358) * copy all files from 2018-01-01 to 2018-02-01 * update api version to 2018 in all files * add express route circuit connection as child of express route bgp peering * update readme.md * add examples * fix travis build error * fix travis build error * fix indentation errors * update reference to circuit connections in peering * fix indentation * Merge Express Route Circuit Connection to Networking2018-02-01 (#2370) * copy all files from 2018-01-01 to 2018-02-01 * update api version to 2018 in all files * add express route circuit connection as child of express route bgp peering * update readme.md * add examples * fix travis build error * fix travis build error * fix indentation errors * update reference to circuit connections in peering * fix indentation * fix indentation * fix indentation' * get latest file * Fix indentation * fix key * fix indentation and example * fix indentation * fix indentation * make circuit con singular * add fix as PR #2364 (#2376) * Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. (#2521) * 1443089: Network feature: Setting custom ipsec policy for Virtual Network Gateway P2S clients. * 1443089:Fix network ReadMe file. * 1443089:Fix network ReadMe file. * Temporary bug fix * Add support for Express Route Provider APIs (#2532) * Add support for Express Route Provider APIs A new top level NRP resource ExpressRouteCrossConnection is being introduced with this change. This resource shadows the customer ExpressRouteCircuit resouce in the customer subscription and enables the provider to perform CRUD operations on some of the sub-resources, such as peerings on the ExpressRoute Circuit * remove wrong enum values from circuit connection status and fix enum … (#2572) * remove wrong enum values from circuit connection status and fix enum name * Update ExpressRouteCrossConnection Route Table Summary Record (#2574) * Update CrossConnection Route Table Summary record * [Network-2018-02-01] DDoS Protection Plan resource (#2567) * Initial version * Add eol * Add extra property in example * Add default values for fields * Rename operation IDs * Make 'id' read-only for all network resources * Revert "Make 'id' read-only for all network resources" * Fix reference * making peer express route circuit peering and express route circuit peering as references (#2696) * Express Route Cross Connection Swagger changes as per PM requirements (#2644) * Fixed operationIds for non-CRUD operations in ExpressRouteCrossConnections (#2720) * Making travis run > 10 mins (#2739)

dedhar added 5 commits January 29, 2018 13:30

copy all files from 2018-01-01 to 2018-02-01

8172f98

update api version to 2018 in all files

fcbbef1

add express route circuit connection as child of express route bgp pe…

c3744fa

…ering

update readme.md

795b2e1

add examples

0b84e97

dsgouda self-requested a review January 29, 2018 22:39

fix travis build error

e85eeb7

marstr assigned marstr and dsgouda Jan 29, 2018

fix travis build error

f1f365b

dsgouda reviewed Jan 30, 2018

View reviewed changes

dsgouda requested a review from DeepakRajendranMsft January 30, 2018 00:06

DeepakRajendranMsft approved these changes Jan 30, 2018

View reviewed changes

dedhar added 2 commits January 29, 2018 16:34

fix indentation errors

0cf2251

update reference to circuit connections in peering

7f89b46

fix indentation

8185b01

dedhar merged commit 814bcbf into Azure:Network-2018-02-01 Jan 30, 2018

AutorestCI mentioned this pull request Jan 30, 2018

Automatic PR of restapi_auto_dedhar_Network-2018-02-01 into restapi_auto_Network-2018-02-01 Azure/azure-sdk-for-python#1850

Merged

AutorestCI mentioned this pull request Jan 30, 2018

Automatic PR of restapi_auto_dedhar_Network-2018-02-01 into restapi_auto_Network-2018-02-01 Azure/azure-sdk-for-go#1013

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API #2358

Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API #2358

dedhar commented Jan 29, 2018

AutorestCI commented Jan 29, 2018

AutorestCI commented Jan 29, 2018

dedhar commented Jan 29, 2018

AutorestCI commented Jan 29, 2018

AutorestCI commented Jan 29, 2018

dsgouda left a comment

dsgouda Jan 30, 2018

dedhar Jan 30, 2018

dsgouda Jan 30, 2018

dedhar Jan 30, 2018

dsgouda Jan 30, 2018

dedhar Jan 30, 2018

dsgouda Jan 30, 2018

dsgouda Jan 30, 2018

dsgouda Jan 30, 2018

dedhar Jan 30, 2018

dsgouda commented Jan 30, 2018 •

edited by DeepakRajendranMsft

Loading

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

azuresdkciprbot commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

azuresdkciprbot commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API #2358

Add support for Express Route Circuit Connection resource as a child of Express Route Circuit Peering in 2018-02-01 API #2358

Conversation

dedhar commented Jan 29, 2018

PR information

Quality of Swagger

AutorestCI commented Jan 29, 2018

AutorestCI commented Jan 29, 2018

dedhar commented Jan 29, 2018

AutorestCI commented Jan 29, 2018

AutorestCI commented Jan 29, 2018

dsgouda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda commented Jan 30, 2018 • edited by DeepakRajendranMsft Loading

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

azuresdkciprbot commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

azuresdkciprbot commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

AutorestCI commented Jan 30, 2018

dsgouda commented Jan 30, 2018 •

edited by DeepakRajendranMsft

Loading