Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfirmConsentCode Endpoint to API Management Authorizations RP #21997

Closed
wants to merge 394 commits into from

Conversation

LFZ96
Copy link
Contributor

@LFZ96 LFZ96 commented Dec 28, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

supriyajha-ms and others added 30 commits November 14, 2022 15:11
* Network Watcher S360 Correctness Fix for 2022-05-01

* prettier fix
…evCenter-2022-11-11-preview' (Azure#21454)

* Adds base for updating Microsoft.DevCenter from version preview/2022-03-01-preview to version 2022-11-11-preview

* Updates readme

* Updates API version in new specs and examples

* Add updated examples and spec

* Run prettier and resolve swagger checks

* Update client loc and format

* Restore URL format to satisfy HostParametersValidation

* Update host template naming

* Update to use "endpoint"

* Update formats and naming

* Remove artifacts

* Remove url formatting

* Expose hibernation support info

* Update naming based on feedback, restore hibernate query param

* Run prettier, fix ref

* Incorporate example changes

* Align param naming

* Align user ID naming

* Remove unnecessary LRO options

* Remove delete environment LRO options

* Fix reference that breaks swagger api view

* Add suppression

* Fix suppression format
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (Azure#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (Azure#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Add canceled to provisioningState enum

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* cherry-pick merge conflict resolution

* storage container changes (Azure#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Change hybrididentitymetadata vmid to resourceUid (Azure#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>
* Initial commit - copy files from previous version

* Changes for v2022-09-01

* Remove unnecessary properties and add description and fix CI issues

* Update databox.json

* Revert "Update databox.json"

This reverts commit 215f002.

* add account id changes, fixed in previous api version

* fix swagger validation issues and account id changes as per previous api version

* fix swagger modelvalidation issue for location header

Co-authored-by: Aakash Saini <rockmyinboxx@gmail.com>
…ently in private preview) to Microsoft.Security RP (Azure#21519)

* Adds base for updating Microsoft.Security from version stable/2021-06-01 to version 2022-11-20-preview

* Updates readme

* Updates API version in new specs and examples

* Add apiCollections.json and relevant examples

* Update readme.md

* Fix validation errors

* Fix validation errors

* One more fix

* Switch to full paths

* More validation fixes

* Try and fix the SDK errors

* Fix avocado error

* Remove operations.json from tag = package-preview-2022-11 based on PR comments
…keswagger' (Azure#21535)

* [AutoSync] 3748a8ea96 add exportsettings in Snowflake source

* [AutoSync] 8a44b7b6ca solve format problem

* [AutoSync] a4fe27d21d use npm format to solve PrettierCheck

* prettier fix

* [AutoSync] 1fb0e7f779 prettier fix

* [AutoSync] b3c6f34cf8 add black line at the end of the file

Co-authored-by: swagger-automation <swagger@microsoft.com>
Co-authored-by: Lei Ni <leni@microsoft.com>
* publishing stable api version 2022-11-01 for load test service

* prettier run

* spell check

* changing swagger back to 2.0

* adding description

* prettier changes

* renaming opertation  id

* adding x-ms-enum extension

* validation fixes

* renaming examples

* review changes

* adding x-ms-parameter-location

* review fixes

* removing required field

* adding x-ms-enum values

* prettier fix

* spell fixes

* prettier fix

* adding new metrics and app component apis

* updating examples

* removing list resource type api

* changing to kebab case

* changing x-ms-parameter-location value for sdk

* updating example

* removing resourceId

* removing resource Id from examples

* adding missing desc

* removing read only properties from examples

* spell fix

* review fixes

* mode renaming

* properties changes in examples

* renaming

* Update loadtestservice.json

* renaming properties

* renaming property

* desc changes

* Add readme SDK changes (Azure#21315)

Co-authored-by: Harshan B <harshanb@microsoft.com>

* review changes

1. adding file with application octet stream
2.taking fileName as param instead of fileId
3. adding new api for metrics dimension values
4. simplifying metrics api

* model validation fixes

* spell fixes

* updating desc for search and orderby

* desc changes

* adding 201 response

* adding 201 status code

Co-authored-by: Krishna Chandak <krchanda@microsoft.com>
Co-authored-by: Harshan B <Harshan01@gmail.com>
Co-authored-by: Harshan B <harshanb@microsoft.com>
Co-authored-by: andrew <andrsmith@microsoft.com>
Azure#21526)

* Duplicate the BaseResolution in analyze-text and analyze-conversations

* Address comments
…\sqlServerInstance resource (Azure#21176)

* adding new values for hostType and new cores property

* removing new property from 2022-03-01 version
* updating common-types to v4

* resolved modelValidation for idFormat & apiVersion

* modelValidation for extensions

* modelValidation resolved for operationList

Co-authored-by: IshitaAsthana <iasthana@microsoft.com>
* doc and example fixes

* Prettier whitespace changes

* trying to fix Newtonsoft.Json.JsonSerializationException: Error converting value NoExplanation to type 'System.Collections.Generic.Dictionary

* attempting to fix validaiton errors

* attempting to fix validaiton errors
Co-authored-by: Zehua Chen <zehuachen@microsoft.com>
…assifications` (Azure#21550)

* Dynamic classification `class` to `classifications`

* Update analyzetext.json

* Update analyzetext.json

* Update analyzetext.json

* update DynamicClassification x-ms-examples

Co-authored-by: Krista Pratico <krpratic@microsoft.com>
* Update readme.python.md

* Update readme.python.md

Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>
* add api version 2022-11-01-preview

* fix api versions in sample

* fix sample

* add dryrun to custom words

* update configurationNames API

Co-authored-by: xiaofanzhou <xiaofanzhou@microsoft.com>
Co-authored-by: Anandaraj Selvam <anselvam@microsoft.com>
* Minor fix on billingBeneifts

* Update billingbenefits.json

* Update billingbenefits.json

* Update billingbenefits.json

* Update billingbenefits.json

* Update billingbenefits.json

* fix examples

* Update billingbenefits.json
…e#21540)

* Adds base for updating Microsoft.SecurityInsights from version stable/2022-08-01 to version 2022-11-01

* Updates readme

* Updates API version in new specs and examples

* SecurityMLAnalyticsSettings to Microsoft.SecurityInsights-2022-11-01-stable (Azure#20944)

* update

* update api versions

* Automation rules 2022-11-01 - alert & update triggers (Azure#21205)

* Automation rules 2022-11-01 stable version

* preetier

* Remove unused url parameters

Co-authored-by: jungph808 <100548649+jungph808@users.noreply.github.com>
Co-authored-by: Dor Siso <60354892+dosiso@users.noreply.github.com>
…ion stable/2022-10-31 (Azure#20374)

* Adds base for updating Microsoft.DigitalTwins from version stable/2022-05-31 to version 2022-10-31

* Updates readme

* Updates API version in new specs and examples

* Introducing 22-10-31 control plane changes for ADt

* Fixing validation errors

* making userAssignedIdentity rx id nullable

* PR feedback

* using common-types

* Revert "using common-types"

This reverts commit 339589c.

* ManagedIdentity -> ManagedIdentityReference

* Add default table and consumer groups

Co-authored-by: Ayodeji Marquis <aymarqui@microsoft.com>
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
… a preview feature, available in the Standard and Premium service tiers (Azure#21623)

Fixes Azure#21603
@LFZ96 LFZ96 requested review from tg-msft and MushMal and removed request for a team January 31, 2023 01:49
This was referenced Jan 31, 2023
@leni-msft
Copy link
Contributor

replaced with #22418

@leni-msft leni-msft closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2022-08-01 APIM 2022-08-01 PRs API Management Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.