Loadtest stableapis #21117

krishna1s · 2022-10-13T19:53:24Z

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your engagement record.

Link to engagement record issue:

Is this review for (select one):

a private preview
a public preview
GA release

Change Scope

^{This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.}

Design Document:
Previous Open API Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Helpful Links

Azure DevTools Wiki

fix #21314

…into loadtest_stableapis

openapi-workflow-bot · 2022-10-13T19:53:27Z

Hi, @krishna1s Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-10-13T19:53:28Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-10-13T19:53:29Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️⌛SDK Breaking Change Tracking pending [Detail]

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from b9f54e3. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from b9f54e3. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.2.0` to update!
cmderr	[automation_generate.sh] npm notice
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from b9f54e3. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-developer-loadtesting [View full logs] [Release SDK Changes]
- pom.xml

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from b9f54e3. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:615
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 615 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:702
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 702 | �[0m … rtifacts += �[96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:615
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 615 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.Developer.LoadTesting [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-10-13T19:53:30Z

Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

openapi-workflow-bot · 2022-10-13T19:55:55Z

Hi @krishna1s, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

krishna1s · 2022-10-13T20:09:52Z

@mikekistler Hi Mike, we are releasing the first stable version of our data plane APIs as our service is going into GA soon. Please review and let us know your feedback.

specification/loadtestservice/data-plane/readme.md

Co-authored-by: Harshan B <harshanb@microsoft.com>

1. adding file with application octet stream 2.taking fileName as param instead of fileId 3. adding new api for metrics dimension values 4. simplifying metrics api

krishna1s · 2022-11-08T14:04:37Z

@mikekistler we have pushed all the review changes. Some more changes done, as we have discussed

New metric dimension value API
all file APIs will take fileName as a param instead of fileId because for file upload we used fileName
Metrics API response is simplified and added next link

mikekistler

This looks very good! 👍

I left a few minor comments that I expect are easy fixes so I'll approve now.

.../loadtestservice/data-plane/Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json

krishna1s · 2022-11-15T07:55:08Z

@mikekistler do we need any further approval on this PR or can we merge this?

mikekistler · 2022-11-15T17:14:01Z

@jhendrixMSFT I think this PR is good to merge. Will you do the honors please?

* publishing stable api version 2022-11-01 for load test service * prettier run * spell check * changing swagger back to 2.0 * adding description * prettier changes * renaming opertation id * adding x-ms-enum extension * validation fixes * renaming examples * review changes * adding x-ms-parameter-location * review fixes * removing required field * adding x-ms-enum values * prettier fix * spell fixes * prettier fix * adding new metrics and app component apis * updating examples * removing list resource type api * changing to kebab case * changing x-ms-parameter-location value for sdk * updating example * removing resourceId * removing resource Id from examples * adding missing desc * removing read only properties from examples * spell fix * review fixes * mode renaming * properties changes in examples * renaming * Update loadtestservice.json * renaming properties * renaming property * desc changes * Add readme SDK changes (Azure#21315) Co-authored-by: Harshan B <harshanb@microsoft.com> * review changes 1. adding file with application octet stream 2.taking fileName as param instead of fileId 3. adding new api for metrics dimension values 4. simplifying metrics api * model validation fixes * spell fixes * updating desc for search and orderby * desc changes * adding 201 response * adding 201 status code Co-authored-by: Krishna Chandak <krchanda@microsoft.com> Co-authored-by: Harshan B <Harshan01@gmail.com> Co-authored-by: Harshan B <harshanb@microsoft.com>

Krishna Chandak added 2 commits October 14, 2022 01:19

publishing stable api version 2022-11-01 for load test service

906201b

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

7211951

…into loadtest_stableapis

krishna1s requested a review from mikekistler as a code owner October 13, 2022 19:53

openapi-assignment-bot bot assigned jhendrixMSFT Oct 13, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Oct 13, 2022

AzureRestAPISpecReview added the data-plane label Oct 13, 2022

prettier run

8153aa1

Krishna Chandak added 2 commits October 14, 2022 12:24

spell check

446e44f

changing swagger back to 2.0

b7005b0

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 14, 2022

krishna1s and others added 6 commits October 14, 2022 14:49

adding description

fc98996

prettier changes

ba39907

renaming opertation id

9a14c71

adding x-ms-enum extension

e9c61e9

validation fixes

db08152

renaming examples

d98fbad

mikekistler added Load Test Service Azure Load Test Service and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReview resource-manager labels Oct 14, 2022

mikekistler requested review from markweitzel and MushMal October 14, 2022 14:39

renaming property

40e0953

AzureRestAPISpecReview removed the CI-FixRequiredOnFailure label Nov 1, 2022

johanste reviewed Nov 1, 2022

View reviewed changes

specification/loadtestservice/data-plane/readme.md Outdated Show resolved Hide resolved

Krishna Chandak and others added 3 commits November 2, 2022 14:35

desc changes

f091772

Merge branch 'main' into loadtest_stableapis

89e55fb

Add readme SDK changes (#21315)

f3b6e41

Co-authored-by: Harshan B <harshanb@microsoft.com>

This was referenced Nov 3, 2022

[AutoPR Azure.Developer.LoadTesting] Loadtest stableapis azure-sdk/azure-sdk-for-net#1467

Closed

[AutoPR azure-developer-loadtesting] Loadtest stableapis azure-sdk/azure-sdk-for-java#2760

Closed

Krishna Chandak added 2 commits November 8, 2022 18:43

review changes

f7da319

1. adding file with application octet stream 2.taking fileName as param instead of fileId 3. adding new api for metrics dimension values 4. simplifying metrics api

model validation fixes

92de85a

AzureRestAPISpecReview added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Nov 8, 2022

spell fixes

aabd5f3

Krishna Chandak added 2 commits November 8, 2022 20:25

updating desc for search and orderby

a2f647b

desc changes

72119f0

mikekistler approved these changes Nov 10, 2022

View reviewed changes

.../loadtestservice/data-plane/Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json Show resolved Hide resolved

.../loadtestservice/data-plane/Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json Outdated Show resolved Hide resolved

adding 201 response

d7b19b7

AzureRestAPISpecReview added the CI-FixRequiredOnFailure label Nov 15, 2022

adding 201 status code

795a99e

AzureRestAPISpecReview removed the CI-FixRequiredOnFailure label Nov 15, 2022

jhendrixMSFT merged commit b9f54e3 into main Nov 15, 2022

jhendrixMSFT deleted the loadtest_stableapis branch November 15, 2022 17:39

azure-sdk mentioned this pull request Nov 15, 2022

[ReleasePR Azure.Developer.LoadTesting] updating examples Azure/azure-sdk-for-net#32492

Closed

azure-sdk mentioned this pull request Dec 15, 2022

[ReleasePR azure-developer-loadtesting] updating examples Azure/azure-sdk-for-java#32283

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Loadtest stableapis #21117

Loadtest stableapis #21117

krishna1s commented Oct 13, 2022 •

edited by azure-sdk

Loading

openapi-workflow-bot bot commented Oct 13, 2022

openapi-pipeline-app bot commented Oct 13, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 13, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 13, 2022 •

edited

Loading

openapi-workflow-bot bot commented Oct 13, 2022

krishna1s commented Oct 13, 2022

krishna1s commented Nov 8, 2022

mikekistler left a comment

krishna1s commented Nov 15, 2022

mikekistler commented Nov 15, 2022

Loadtest stableapis #21117

Loadtest stableapis #21117

Conversation

krishna1s commented Oct 13, 2022 • edited by azure-sdk Loading

Data Plane API - Pull Request

API Info: The Basics

Change Scope

❔Got questions? Need additional info?? We are here to help!

Tooling

Guidelines & Specifications

Helpful Links

openapi-workflow-bot bot commented Oct 13, 2022

openapi-pipeline-app bot commented Oct 13, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 13, 2022 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Oct 13, 2022 • edited Loading

openapi-workflow-bot bot commented Oct 13, 2022

krishna1s commented Oct 13, 2022

krishna1s commented Nov 8, 2022

mikekistler left a comment

Choose a reason for hiding this comment

krishna1s commented Nov 15, 2022

mikekistler commented Nov 15, 2022

krishna1s commented Oct 13, 2022 •

edited by azure-sdk

Loading

openapi-pipeline-app bot commented Oct 13, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 13, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 13, 2022 •

edited

Loading