Add ConfirmConsentCode Endpoint to API Management Authorizations RP

.azure-pipelines/azure-pipelines-data-container.yml

@@ -7,7 +7,7 @@ schedules:
   always: true
 
 pool:
-  vmImage: 'Ubuntu-20.04'
+  vmImage: 'Ubuntu-22.04'
 
 variables:
   IMAGE_TAG_PREFIX: $[format('1.0.{0:HHm}', pipeline.startTime)]

.github/comment.yml

@@ -16,6 +16,16 @@
         openapiHub: https://portal.azure-devex-tools.com
     onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. </br>**Action**: To initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).</br> If you want to know the production traffic statistic, please see [ARM Traffic statistic](${openapiHub}/api/pr/query-traffic?pr=${owner}/${repo}/${PRNumber}&days=5). </br> If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. </br> **Note**: To avoid breaking change, you can refer to [Shift Left Solution](https://aka.ms/shiftleft) for detecting breaking change in early phase at your service code repository."
 
+- rule:
+    type: label
+    label: SuppressionReviewRequired
+    onLabeledComments: "Hi @${PRAuthor}, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the [Swagger-Suppression-Process](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process) to get approval."
+
+- rule:
+    type: label
+    label: "CI-MissingBaseCommit"
+    onLabeledComments: "Hi, @${PRAuthor}, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version). Or you could onboard [API spec pipeline](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/606/Enable-API-Spec-Pipeline)"
+
 - rule:
     type: label
     repoAllowList:
@@ -31,6 +41,21 @@
     label: NewApiVersionRequired
     onLabeledComments: "<b>NewApiVersionRequired reason:</b></br> </br><b>A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. </b> </br></br> EXAMPLE: if a customer calls a service in the public cloud using <b>api-version=2020-07-27</b>, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.  "
 
+- rule:
+    type: label
+    label: CI-NewRPNamespaceWithoutRPaaS
+    onLabeledComments: "Hi @${PRAuthor} This PR was flagged for introducing a new RP namespace that is not being onboarded with [RPaaS](https://armwiki.azurewebsites.net/rpaas/overview.html). Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please [use RPaaS to onboard the new RP](https://armwiki.azurewebsites.net/rpaas/gettingstarted.html)."
+
+- rule:
+    type: label
+    label: CI-RpaaSRPNotInPrivateRepo
+    onLabeledComments: "Hi @${PRAuthor} This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main."
+
+- rule:
+    type: label
+    label: ArcReview
+    onLabeledComments: "Hi @${PRAuthor} and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at [Consistency in ARM Modeling](https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/377428/Consistency-in-ARM-Modeling?anchor=general-design-guidance). To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to arcboard@microsoft.com."
+
 - rule:
     type: label
     label: CI-FixRequiredOnFailure

.github/fabricbot.json

@@ -2362,7 +2362,6 @@
               "Search"
             ],
             "mentionees": [
-              "brjohnstmsft",
               "bleroy",
               "tjacobhi",
               "markheff",
@@ -3123,6 +3122,12 @@
               "label": "no-recent-activity"
             }
           },
+          {
+            "name": "noLabel",
+            "parameters": {
+              "label": "customer-reported"
+            }
+          },
           {
             "name": "isPr",
             "parameters": {}
@@ -3225,6 +3230,12 @@
             "parameters": {
               "days": 14
             }
+          },
+          {
+            "name": "noLabel",
+            "parameters": {
+              "label": "customer-reported"
+            }
           }
         ],
         "taskName": "Close stale PR (no update for 30 days)",
@@ -4168,7 +4179,7 @@
             "pathFilter": [
               "specification/loadtestservice/"
             ],
-            "exclude":[
+            "exclude": [
               ""
             ]
           },
@@ -4177,7 +4188,7 @@
             "pathFilter": [
               "specification/maps/"
             ],
-            "exclude":[
+            "exclude": [
               ""
             ]
           },
@@ -4186,7 +4197,7 @@
             "pathFilter": [
               "specification/purview/"
             ],
-            "exclude":[
+            "exclude": [
               ""
             ]
           },
@@ -4225,6 +4236,15 @@
             "exclude": [
               ""
             ]
+          },
+          {
+            "label": "ArcReview",
+            "pathFilter": [
+              "specification/hybridcompute/resource-manager/",
+              "specification/connectedvmware/resource-manager/",
+              "specification/azurestackhci/resource-manager/",
+              "specification/scvmm/resource-manager/"
+            ]
           }
         ],
         "taskName": "Auto PR based on folder paths "
@@ -4901,4 +4921,4 @@
       ]
     }
   ]
-}
+}

.github/pull_request_assignment.yml

@@ -87,11 +87,25 @@
 
 
 - rule:
-    paths: "specification/@(providerhub|sql|appplatform|deviceupdate|servicelinker|imagebuilder|throttling|secretmanagementtestsvc)/**"
+    paths: "specification/@(providerhub|sql|appplatform|deviceupdate|servicelinker|imagebuilder|throttling|secretmanagementtestsvc|containerservice|azure-kusto)/**"
+    reviewers:
+      - raych1
+      - xiaoxuqi-ms
+
+- rule:
+    paths: "specification/voiceservices/**"
     reviewers:
       - raych1
       - xiaoxuqi-ms
 
+- rule:
+    paths: "specification/@(financialdataservices|standbypool)/**"
+    reviewers:
+      - jianyexi
+      - xiaoxuqi-ms
+    branches:
+      - RPSaaSDev
+
 - rule:
     paths: "specification/sql/**"
     reviewers:
@@ -242,6 +256,6 @@
       - dw511214992
       - honghr
       - tianxchen-ms
-      - tadelesh
       - xiaoxuqi-ms
       - live1206
+      - tadelesh

.github/sla.yml

@@ -28,6 +28,22 @@
         - ${AUTHOR}
         - ${ASSIGNEE}
 
+
+- scheduleTask:
+    action: sendEmail
+    scope: pull_request
+    name: "send email to Arc review board"
+    trigger:
+      - label
+    args:
+      booleanFilterExpression: "ArcReview"
+      message: "<p>Hi, Arc review board,</p><p>Please review the PR ${URL} . You receive the email because the PR is labeled with ArcReview. <br> One or more change(s) have been detected in your Arc enabled VM or Arc enabled Server RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), add the label ArcSignedOff.</p>"
+      subject: "Action Required ArcReview: Please review PR ${URL}"
+      to: arcboard@microsoft.com
+      cc:
+        - ${AUTHOR}
+        - ${ASSIGNEE}
+
 - scheduleTask:
     action: sendEmail
     scope: pull_request

.github/syncRepoFiles/index.js

@@ -45,7 +45,8 @@ try {
             key: 'FILE_PATH'
         }),
         GITHUB_TOKEN: getInput({
-            key: 'GITHUB_TOKEN'
+            key: 'GITHUB_TOKEN',
+            required: true
         }),
         COMMIT_BODY: getInput({
             key: 'COMMIT_BODY',
@@ -91,6 +92,7 @@ try {
         })
     };
     core.setSecret(context.GITHUB_TOKEN);
+    console.log('context', context);
     core.debug(JSON.stringify(context, null, 2));
 }
 catch (err) {
@@ -261,9 +263,34 @@ class Git {
             return yield this.github.git.createRef(createRefRequest);
         });
     }
-    createBranch(branchRequest, commitResult, newBranch) {
+    createOrUpdateBranch(branchRequest, commitResult, newBranch) {
         return __awaiter(this, void 0, void 0, function* () {
-            return yield this.github.git.createRef(Object.assign(Object.assign({}, _.pick(branchRequest, ['owner', 'repo'])), { ref: `refs/heads/${newBranch}`, sha: commitResult.data.sha }));
+            const isExistingBranch = yield this.isBranchExist(branchRequest, newBranch);
+            if (isExistingBranch) {
+                core.info(`branch has been update successfully`);
+                try {
+                    yield this.github.repos.merge(Object.assign(Object.assign({}, _.pick(branchRequest, ['owner', 'repo'])), { base: newBranch, head: commitResult.data.sha, commit_message: 'Update branch' }));
+                }
+                catch (error) {
+                    core.warning(`${error}`);
+                }
+            }
+            else {
+                core.info(`branch has been created successfully`);
+                yield this.github.git.createRef(Object.assign(Object.assign({}, _.pick(branchRequest, ['owner', 'repo'])), { ref: `refs/heads/${newBranch}`, sha: commitResult.data.sha }));
+            }
+        });
+    }
+    isBranchExist(branchRequest, newBranchName) {
+        return __awaiter(this, void 0, void 0, function* () {
+            try {
+                const branch = yield this.github.repos.getBranch(Object.assign(Object.assign({}, _.pick(branchRequest, ['owner', 'repo'])), { branch: newBranchName }));
+                return branch;
+            }
+            catch (error) {
+                core.info(`${error}`);
+                return false;
+            }
         });
     }
     pullRequestAdd(branchRequest, pullRequest, labels, assignees, reviewers, teamReviewers) {
@@ -304,8 +331,14 @@ class Git {
     }
     findExistingPr(branchRequest, newBranch) {
         return __awaiter(this, void 0, void 0, function* () {
-            const pullRequestList = yield this.github.pulls.list(Object.assign(Object.assign({}, _.pick(branchRequest, ['owner', 'repo'])), { state: 'open', head: `${_.pick(branchRequest, ['owner']).owner}:${newBranch}` }));
-            return pullRequestList.data[0];
+            try {
+                const pullRequestList = yield this.github.pulls.list(Object.assign(Object.assign({}, _.pick(branchRequest, ['owner', 'repo'])), { state: 'open', head: `${_.pick(branchRequest, ['owner']).owner}:${newBranch}` }));
+                return pullRequestList.data[0];
+            }
+            catch (error) {
+                core.info(`${error}`);
+                return false;
+            }
         });
     }
     getChangeFileContent(branchRequest, filePath) {
@@ -403,19 +436,16 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 const core = __importStar(__nccwpck_require__(2186));
-const github = __importStar(__nccwpck_require__(5438));
 const config_1 = __importDefault(__nccwpck_require__(88));
 const github_1 = __nccwpck_require__(5928);
 const utils_1 = __nccwpck_require__(918);
 function run() {
     return __awaiter(this, void 0, void 0, function* () {
-        core.info(`GITHUB_TOKEN ${config_1.default.GITHUB_TOKEN} ${typeof config_1.default.GITHUB_TOKEN}`);
-        core.info(`${JSON.stringify(github.context)}`);
-        // JackTn/script_github_actions@main
+        core.info(`Now it's running ~ 😊`);
         const regExp = /([^\/)]*)\/([^@]*)@(.*)/;
         const sourceList = regExp.exec(config_1.default.SOURCE);
         const destList = regExp.exec(config_1.default.DEST);
-        if (!destList && !sourceList) {
+        if (!destList || !sourceList) {
             core.warning(`input is missing correct`);
             process.exit(1);
         }
@@ -433,31 +463,32 @@ function run() {
         const commitMessage = `${config_1.default.COMMIT_PREFIX} Synced local '${filePath}'`;
         const GITHUB_REPOSITORY = `${source.owner}/${source.repo}`;
         const branchName = `${config_1.default.BRANCH_PREFIX}/${dest.owner}/${dest.repo}/${dest.branch}`;
-        const pullRequestTitle = `${config_1.default.COMMIT_PREFIX} Synced file(s) with ${GITHUB_REPOSITORY}`;
-        const GITHUB_TOKEN = config_1.default.GITHUB_TOKEN;
-        const git = new github_1.Git(GITHUB_TOKEN);
-        const changeFileContent = yield git.getChangeFileContent(source, filePath);
-        const pullRequestBody = (0, utils_1.dedent)(`Synced local file(s) with [${GITHUB_REPOSITORY}](https://github.com/${GITHUB_REPOSITORY})
+        const pullRequestTitle = `${config_1.default.COMMIT_PREFIX} Sync from ${source.branch} branch`;
+        const pullRequestBody = (0, utils_1.dedent)(`This pr synced the latest changes of ${filePath} from ${source.branch} branch
 
                                 ---
 
                                 This PR was created automatically and this workflow run [#${process.env.GITHUB_RUN_ID || 0}](https://github.com/${GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID || 0})
 
                                 `);
-        const isExistingPR = yield git.findExistingPr(dest, branchName);
+        core.info(`will create pull request by ${branchName} in ${dest.owner}/${dest.repo} from ${GITHUB_REPOSITORY}`);
+        const GITHUB_TOKEN = config_1.default.GITHUB_TOKEN;
+        const git = new github_1.Git(GITHUB_TOKEN);
+        const changeFileContent = yield git.getChangeFileContent(source, filePath);
         const treeList = yield git.getTreeListWithOutPath(dest, filePath);
         const newTree = [...changeFileContent, ...treeList];
-        const createTree = yield git.createTreeAll(dest, newTree, 500);
+        const createTree = yield git.createTreeAll(dest, newTree, config_1.default.CREATE_TREE_LIMIT);
         const createCommit = yield git.addCommit(dest, createTree, commitMessage);
+        yield git.createOrUpdateBranch(dest, createCommit, branchName);
+        const isExistingPR = yield git.findExistingPr(dest, branchName);
         if (isExistingPR) {
             yield git.updatePullRequest(dest, isExistingPR.number, pullRequestTitle, (0, utils_1.dedent)(`
-        ⚠️ This PR is being automatically resync ⚠️
+        ⚠️ This PR was created automatically ⚠️
         ${pullRequestBody}
     `), config_1.default.PR_LABELS, config_1.default.ASSIGNEES, config_1.default.REVIEWERS, config_1.default.TEAM_REVIEWERS);
             core.notice(`Pull Request #${isExistingPR.number} updated: ${isExistingPR.html_url}`);
         }
         else {
-            yield git.createBranch(dest, createCommit, branchName);
             const pullRequest = yield git.createPullRequest(dest, branchName, pullRequestTitle, pullRequestBody, config_1.default.PR_LABELS, config_1.default.ASSIGNEES, config_1.default.REVIEWERS, config_1.default.TEAM_REVIEWERS);
             core.notice(`Pull Request #${pullRequest.data.number} created: ${pullRequest.data.html_url}`);
         }

.github/workflows/sync-repo-files.yml

@@ -1,10 +1,5 @@
  name: sync-common-types-files
  on: 
-   push:
-     branches:
-       - main
-     paths: 
-       - 'specification/common-types/**'
    schedule:
        - cron: '0 8 * * *'
    workflow_dispatch:
@@ -14,40 +9,46 @@
      if: ${{ github.repository == 'Azure/azure-rest-api-specs-pr' }}
      runs-on: ubuntu-latest
      steps:
-       - name: checkoutV2 
-         uses: actions/checkout@v2
+       - name: checkoutV3 
+         uses: actions/checkout@v3
        - name: sync-common-types-files
          uses: ./
          with:
             SOURCE: azure/azure-rest-api-specs-pr@main
             DEST: azure/azure-rest-api-specs-pr@RPSaaSMaster
             FILE_PATH: specification/common-types
             GITHUB_TOKEN: ${{ secrets.AutoSync_GH_PAT }}
+            ASSIGNEES: |
+              raych1
    sync-files-RPSaaSDev:
      name: sync-common-types-files
      if: ${{ github.repository == 'Azure/azure-rest-api-specs-pr' }}
      runs-on: ubuntu-latest
      steps:
-       - name: checkoutV2 
-         uses: actions/checkout@v2
+       - name: checkoutV3 
+         uses: actions/checkout@v3
        - name: sync-common-types-files
          uses: ./
          with:
             SOURCE: azure/azure-rest-api-specs-pr@main
             DEST: azure/azure-rest-api-specs-pr@RPSaaSDev
             FILE_PATH: specification/common-types
             GITHUB_TOKEN: ${{ secrets.AutoSync_GH_PAT }}
+            ASSIGNEES: |
+              raych1
    sync-files-ARMCoreRPDev:
      name: sync-common-types-files
      if: ${{ github.repository == 'Azure/azure-rest-api-specs-pr' }}
      runs-on: ubuntu-latest
      steps:
-       - name: checkoutV2 
-         uses: actions/checkout@v2
+       - name: checkoutV3 
+         uses: actions/checkout@v3
        - name: sync-common-types-files
          uses: ./
          with:
             SOURCE: azure/azure-rest-api-specs-pr@main
             DEST: azure/azure-rest-api-specs-pr@ARMCoreRPDev
             FILE_PATH: specification/common-types
-            GITHUB_TOKEN: ${{ secrets.AutoSync_GH_PAT }}
+            GITHUB_TOKEN: ${{ secrets.AutoSync_GH_PAT }}
+            ASSIGNEES: |
+              raych1