-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve list version #4463
Improve list version #4463
Conversation
You may test this build by running Add the following CLI flags
Or with all autorest --version:https://tinyurl.com/y9689ojb --use:https://tinyurl.com/ycns9527 or use the following in your autorest configuration: # For changes to autorest core
version: "https://tinyurl.com/y9689ojb"
# For changes to modelerfour
use-extension:
"@autorest/modelerfour": "https://tinyurl.com/ycns9527" If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it. |
@timotheeguerin is it going to be a new release per this merge? Thanks! |
@chenrui333 there will be a release soon but not just yet. Probably early next week. As said in the issue this problem isn't really autorest problem(Though it did reveal some improvement I could make. But it still fails later down the pipeline when installing the typescript extension) but a bug introduced in node 17.7.0. There is already a patch version for node fixing the issue: |
make sense, thanks! |
fix #4462
Main issue is a regression introduced in node 17.7.0 however digging into this realized we don't need to call to yarn to list the available version and can use the
pacote
library. This not only solve the issue but also improve reliability when resolving the list of available versions as well as should be faster(No need to call another process)