Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve list version #4463

Merged
merged 12 commits into from
Mar 10, 2022
Merged

Improve list version #4463

merged 12 commits into from
Mar 10, 2022

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Mar 10, 2022

fix #4462

Main issue is a regression introduced in node 17.7.0 however digging into this realized we don't need to call to yarn to list the available version and can use the pacote library. This not only solve the issue but also improve reliability when resolving the list of available versions as well as should be faster(No need to call another process)

@timotheeguerin timotheeguerin requested a review from daviwil as a code owner March 10, 2022 16:51
@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/y9689ojb For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/ycns9527 For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/y9689ojb --use:https://tinyurl.com/ycns9527

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/y9689ojb"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/ycns9527"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@timotheeguerin timotheeguerin merged commit c57f071 into main Mar 10, 2022
@timotheeguerin timotheeguerin deleted the improve-list-versions branch March 10, 2022 22:10
@chenrui333
Copy link

@timotheeguerin is it going to be a new release per this merge? Thanks!

@timotheeguerin
Copy link
Member Author

timotheeguerin commented Mar 10, 2022

@chenrui333 there will be a release soon but not just yet. Probably early next week. As said in the issue this problem isn't really autorest problem(Though it did reveal some improvement I could make. But it still fails later down the pipeline when installing the typescript extension) but a bug introduced in node 17.7.0. There is already a patch version for node fixing the issue: 17.7.1 and make the latest published autorest work fine.

@chenrui333
Copy link

make sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[homebrew] regression test failure with node 17.7.0
2 participants