Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 17.7.1 #96599

Closed
wants to merge 1 commit into from
Closed

node 17.7.1 #96599

wants to merge 1 commit into from

Conversation

derrabus
Copy link
Contributor

@derrabus derrabus commented Mar 9, 2022 •
edited
Loading

Created with brew bump-formula-pr.

resource blocks may require updates. ✅

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing labels Mar 9, 2022
@derrabus
Copy link
Contributor Author

derrabus commented Mar 9, 2022

Someone needs to adjust the labels on this PR to make the CI happy, I guess.

@branchvincent branchvincent added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 9, 2022
@Bo98 Bo98 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Mar 9, 2022
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Mar 10, 2022
@carlocab
Copy link
Member

autorest failed everywhere and looks like it could be a genuine regression. @chenrui333 do you mind taking a look since you changed the test recently?

@chenrui333
Copy link
Member

Sure, let me take a look.

@chenrui333
Copy link
Member

I can reproduce the issue in my local, and it is reported in here

@chenrui333 chenrui333 mentioned this pull request Mar 10, 2022
Closed
2 tasks
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Mar 10, 2022
@cho-m cho-m added the upstream issue An upstream issue report is needed label Mar 10, 2022
@cho-m
Copy link
Member

cho-m commented Mar 10, 2022

Either can wait for node 17.7.1 (nodejs/node#42285) which may be out quickly due to breakage or apply commit nodejs/node@f91950c

@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 10, 2022
@chenrui333
Copy link
Member

Should be fixed with this.

@Bo98
Copy link
Member

Bo98 commented Mar 10, 2022

Let's wait until 17.7.1.

@derrabus derrabus changed the title node 17.7.0 node 17.7.1 Mar 10, 2022
@derrabus
Copy link
Contributor Author

17.7.1 has been released. I've updated the PR.

@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 10, 2022
@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 11, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@chenrui333 chenrui333 removed upstream issue An upstream issue report is needed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Mar 11, 2022
@derrabus derrabus deleted the bump-node-17.7.0 branch March 11, 2022 08:35
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cho-m cho-m cho-m approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@derrabus @carlocab @chenrui333 @cho-m @Bo98 @BrewTestBot @branchvincent