Improve list version (#4463)

Azure · Mar 10, 2022 · c57f071 · c57f071
1 parent 46e690a
commit c57f071
Show file tree

Hide file tree

Showing 15 changed files with 312 additions and 327 deletions.
diff --git a/common/changes/@azure-tools/codegen/improve-list-versions_2022-03-10-16-52.json b/common/changes/@azure-tools/codegen/improve-list-versions_2022-03-10-16-52.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@azure-tools/codegen",
+      "comment": "Bump `semver` dependency",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@azure-tools/codegen",
+  "email": "tiguerin@microsoft.com"
+}
diff --git a/common/changes/@azure-tools/extension/improve-list-versions_2022-03-10-16-52.json b/common/changes/@azure-tools/extension/improve-list-versions_2022-03-10-16-52.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@azure-tools/extension",
+      "comment": "Stop using shell call to `yarn` or `npm` to resolve list of available version and use `pactote` library. Improving reliability and performance.",
+      "type": "minor"
+    }
+  ],
+  "packageName": "@azure-tools/extension",
+  "email": "tiguerin@microsoft.com"
+}
diff --git a/common/changes/autorest/improve-list-versions_2022-03-10-16-52.json b/common/changes/autorest/improve-list-versions_2022-03-10-16-52.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "autorest",
+      "comment": "Cleanup logic with using `--list-available`.",
+      "type": "minor"
+    }
+  ],
+  "packageName": "autorest",
+  "email": "tiguerin@microsoft.com"
+}
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/packages/apps/autorest/package.json b/packages/apps/autorest/package.json
@@ -73,7 +73,7 @@
     "prettier": "~2.3.1",
     "rimraf": "^3.0.2",
     "safe-buffer": "5.2.0",
-    "semver": "^5.5.1",
+    "semver": "^7.3.5",
     "source-map-support": "^0.5.19",
     "source-map": "0.7.3",
     "ts-jest": "^27.0.3",

diff --git a/packages/apps/autorest/src/autorest-as-a-service.ts b/packages/apps/autorest/src/autorest-as-a-service.ts
@@ -57,13 +57,7 @@ export async function availableVersions() {
       const vers = (await (await extensionManager).getPackageVersions(newCorePackage)).sort((b, a) =>
         semver.compare(a, b),
       );
-      const result = new Array<string>();
-      for (const ver of vers) {
-        if (semver.satisfies(ver, versionRange)) {
-          result.push(ver);
-        }
-      }
-      return result;
+      return vers.filter((x) => semver.satisfies(x, versionRange));
     } catch (e) {
       console.info(`No available versions of package ${newCorePackage} found.`);
     }