Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Solution Activity Log from LAW #415

Merged
merged 4 commits into from
Dec 23, 2022

Conversation

lachaves
Copy link
Contributor

@lachaves lachaves commented Dec 12, 2022

Overview/Summary

Remove Activity Log solution from Bicep RI
Update and Bicep documentation referencing this

This PR fixes/adds/changes/removes

  1. PR Remove Activity Log from Bicep RI #414
  2. Closes AB#25141

Breaking Changes

  1. None

Testing Evidence

Executed the deployment and Activity Log Solution is not deployed.

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Dec 12, 2022
@jtracey93 jtracey93 added Area: Logging & Automation and removed Needs: Triage 🔍 Needs triaging by the team labels Dec 12, 2022
Copy link
Contributor

@4pplied 4pplied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just need to remove detail from parameter descriptions to start a standardisation!

infra-as-code/bicep/modules/logging/logging.bicep Outdated Show resolved Hide resolved
@ghost ghost removed the Needs: Author Feedback label Dec 22, 2022
Copy link
Contributor

@4pplied 4pplied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 131f1f6 into Azure:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants