Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Solution Activity Log from LAW #415

Merged
merged 4 commits into from
Dec 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion infra-as-code/bicep/modules/logging/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ The module will deploy the following Log Analytics Workspace solutions by defaul

- AgentHealthAssessment
- AntiMalware
- AzureActivity
- ChangeTracking
- Security
- SecurityInsights (Azure Sentinel)
Expand Down
45 changes: 22 additions & 23 deletions infra-as-code/bicep/modules/logging/generateddocs/logging.bicep.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,39 +6,39 @@ ALZ Bicep Module used to set up Logging

Parameter name | Required | Description
-------------- | -------- | -----------
parLogAnalyticsWorkspaceName | No | Log Analytics Workspace name. Default: alz-log-analytics
parLogAnalyticsWorkspaceLocation | No | Log Analytics region name - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings. Default: resourceGroup().location
parLogAnalyticsWorkspaceSkuName | No | Log Analytics Workspace sku name. Default: PerGB2018
parLogAnalyticsWorkspaceLogRetentionInDays | No | Number of days of log retention for Log Analytics Workspace. Default: 365
parLogAnalyticsWorkspaceSolutions | No | Solutions that will be added to the Log Analytics Workspace. Default: [AgentHealthAssessment, AntiMalware, AzureActivity, ChangeTracking, Security, SecurityInsights, ServiceMap, SQLAssessment, Updates, VMInsights]
parAutomationAccountName | No | Automation account name. - Default: alz-automation-account
parAutomationAccountLocation | No | Automation Account region name. - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings. Default: resourceGroup().location
parTags | No | Tags you would like to be applied to all resources in this module. Default: Empty Object
parAutomationAccountTags | No | Tags you would like to be applied to Automation Account. Default: parTags
parLogAnalyticsWorkspaceTags | No | Tags you would like to be applied to Log Analytics Workspace. Default: parTags
parLogAnalyticsWorkspaceName | No | Log Analytics Workspace name.
parLogAnalyticsWorkspaceLocation | No | Log Analytics region name - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings.
parLogAnalyticsWorkspaceSkuName | No | Log Analytics Workspace sku name.
parLogAnalyticsWorkspaceLogRetentionInDays | No | Number of days of log retention for Log Analytics Workspace.
parLogAnalyticsWorkspaceSolutions | No | Solutions that will be added to the Log Analytics Workspace.
parAutomationAccountName | No | Automation account name.
parAutomationAccountLocation | No | Automation Account region name. - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings.
parTags | No | Tags you would like to be applied to all resources in this module.
parAutomationAccountTags | No | Tags you would like to be applied to Automation Account.
parLogAnalyticsWorkspaceTags | No | Tags you would like to be applied to Log Analytics Workspace.
parTelemetryOptOut | No | Set Parameter to true to Opt-out of deployment telemetry

### parLogAnalyticsWorkspaceName

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Log Analytics Workspace name. Default: alz-log-analytics
Log Analytics Workspace name.

- Default value: `alz-log-analytics`

### parLogAnalyticsWorkspaceLocation

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Log Analytics region name - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings. Default: resourceGroup().location
Log Analytics region name - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings.

- Default value: `[resourceGroup().location]`

### parLogAnalyticsWorkspaceSkuName

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Log Analytics Workspace sku name. Default: PerGB2018
Log Analytics Workspace sku name.

- Default value: `PerGB2018`

Expand All @@ -48,55 +48,55 @@ Log Analytics Workspace sku name. Default: PerGB2018

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Number of days of log retention for Log Analytics Workspace. Default: 365
Number of days of log retention for Log Analytics Workspace.

- Default value: `365`

### parLogAnalyticsWorkspaceSolutions

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Solutions that will be added to the Log Analytics Workspace. Default: [AgentHealthAssessment, AntiMalware, AzureActivity, ChangeTracking, Security, SecurityInsights, ServiceMap, SQLAssessment, Updates, VMInsights]
Solutions that will be added to the Log Analytics Workspace.

- Default value: `AgentHealthAssessment AntiMalware AzureActivity ChangeTracking Security SecurityInsights ServiceMap SQLAdvancedThreatProtection SQLVulnerabilityAssessment SQLAssessment Updates VMInsights`
- Default value: `AgentHealthAssessment AntiMalware ChangeTracking Security SecurityInsights ServiceMap SQLAdvancedThreatProtection SQLVulnerabilityAssessment SQLAssessment Updates VMInsights`

- Allowed values: `AgentHealthAssessment`, `AntiMalware`, `AzureActivity`, `ChangeTracking`, `Security`, `SecurityInsights`, `ServiceMap`, `SQLAdvancedThreatProtection`, `SQLVulnerabilityAssessment`, `SQLAssessment`, `Updates`, `VMInsights`
- Allowed values: `AgentHealthAssessment`, `AntiMalware`, `ChangeTracking`, `Security`, `SecurityInsights`, `ServiceMap`, `SQLAdvancedThreatProtection`, `SQLVulnerabilityAssessment`, `SQLAssessment`, `Updates`, `VMInsights`

### parAutomationAccountName

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Automation account name. - Default: alz-automation-account
Automation account name.

- Default value: `alz-automation-account`

### parAutomationAccountLocation

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Automation Account region name. - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings. Default: resourceGroup().location
Automation Account region name. - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings.

- Default value: `[resourceGroup().location]`

### parTags

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Tags you would like to be applied to all resources in this module. Default: Empty Object
Tags you would like to be applied to all resources in this module.

### parAutomationAccountTags

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Tags you would like to be applied to Automation Account. Default: parTags
Tags you would like to be applied to Automation Account.

- Default value: `[parameters('parTags')]`

### parLogAnalyticsWorkspaceTags

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Tags you would like to be applied to Log Analytics Workspace. Default: parTags
Tags you would like to be applied to Log Analytics Workspace.

- Default value: `[parameters('parTags')]`

Expand Down Expand Up @@ -147,7 +147,6 @@ outAutomationAccountId | string |
"value": [
"AgentHealthAssessment",
"AntiMalware",
"AzureActivity",
"ChangeTracking",
"Security",
"SecurityInsights",
Expand Down
22 changes: 10 additions & 12 deletions infra-as-code/bicep/modules/logging/logging.bicep
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
metadata name = 'ALZ Bicep - Logging Module'
metadata description = 'ALZ Bicep Module used to set up Logging'

@sys.description('Log Analytics Workspace name. Default: alz-log-analytics')
@sys.description('Log Analytics Workspace name.')
param parLogAnalyticsWorkspaceName string = 'alz-log-analytics'

@sys.description('Log Analytics region name - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings. Default: resourceGroup().location')
@sys.description('Log Analytics region name - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings.')
param parLogAnalyticsWorkspaceLocation string = resourceGroup().location

@allowed([
Expand All @@ -17,18 +17,17 @@ param parLogAnalyticsWorkspaceLocation string = resourceGroup().location
'Standalone'
'Standard'
])
@sys.description('Log Analytics Workspace sku name. Default: PerGB2018')
@sys.description('Log Analytics Workspace sku name.')
param parLogAnalyticsWorkspaceSkuName string = 'PerGB2018'

@minValue(30)
@maxValue(730)
@sys.description('Number of days of log retention for Log Analytics Workspace. Default: 365')
@sys.description('Number of days of log retention for Log Analytics Workspace.')
param parLogAnalyticsWorkspaceLogRetentionInDays int = 365

@allowed([
'AgentHealthAssessment'
'AntiMalware'
'AzureActivity'
'ChangeTracking'
'Security'
'SecurityInsights'
Expand All @@ -39,11 +38,10 @@ param parLogAnalyticsWorkspaceLogRetentionInDays int = 365
'Updates'
'VMInsights'
])
@sys.description('Solutions that will be added to the Log Analytics Workspace. Default: [AgentHealthAssessment, AntiMalware, AzureActivity, ChangeTracking, Security, SecurityInsights, ServiceMap, SQLAssessment, Updates, VMInsights]')
@sys.description('Solutions that will be added to the Log Analytics Workspace.')
param parLogAnalyticsWorkspaceSolutions array = [
'AgentHealthAssessment'
'AntiMalware'
'AzureActivity'
'ChangeTracking'
'Security'
'SecurityInsights'
Expand All @@ -55,19 +53,19 @@ param parLogAnalyticsWorkspaceSolutions array = [
'VMInsights'
]

@sys.description('Automation account name. - Default: alz-automation-account')
@sys.description('Automation account name.')
param parAutomationAccountName string = 'alz-automation-account'

@sys.description('Automation Account region name. - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings. Default: resourceGroup().location')
@sys.description('Automation Account region name. - Ensure the regions selected is a supported mapping as per: https://docs.microsoft.com/azure/automation/how-to/region-mappings.')
param parAutomationAccountLocation string = resourceGroup().location

@sys.description('Tags you would like to be applied to all resources in this module. Default: Empty Object')
@sys.description('Tags you would like to be applied to all resources in this module.')
param parTags object = {}

@sys.description('Tags you would like to be applied to Automation Account. Default: parTags')
@sys.description('Tags you would like to be applied to Automation Account.')
param parAutomationAccountTags object = parTags

@sys.description('Tags you would like to be applied to Log Analytics Workspace. Default: parTags')
@sys.description('Tags you would like to be applied to Log Analytics Workspace.')
param parLogAnalyticsWorkspaceTags object = parTags

@sys.description('Set Parameter to true to Opt-out of deployment telemetry')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"value": [
"AgentHealthAssessment",
"AntiMalware",
"AzureActivity",
"ChangeTracking",
"Security",
"SecurityInsights",
Expand All @@ -45,4 +44,4 @@
"value": false
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"value": [
"AgentHealthAssessment",
"AntiMalware",
"AzureActivity",
"ChangeTracking",
"Security",
"SecurityInsights",
Expand All @@ -31,4 +30,4 @@
"value": false
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"value": [
"AgentHealthAssessment",
"AntiMalware",
"AzureActivity",
"ChangeTracking",
"Security",
"SecurityInsights",
Expand All @@ -45,4 +44,4 @@
"value": false
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"value": [
"AgentHealthAssessment",
"AntiMalware",
"AzureActivity",
"ChangeTracking",
"Security",
"SecurityInsights",
Expand All @@ -31,4 +30,4 @@
"value": false
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ module baseline_logging '../logging.bicep' = {
parLogAnalyticsWorkspaceSolutions: [
'AgentHealthAssessment'
'AntiMalware'
'AzureActivity'
'ChangeTracking'
'Security'
'SecurityInsights'
Expand Down