Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #410 - Remove default values from parameter descriptions #421

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Issue #410 - Remove default values from parameter descriptions #421

merged 3 commits into from
Jan 4, 2023

Conversation

4pplied
Copy link
Contributor

@4pplied 4pplied commented Dec 22, 2022

Overview/Summary

Removed the default values from the parameter descriptions as they are displayed in the generated markdown files.
NOTE: This has not been done for the Logging module in this PR. This is in PR: #415

This PR fixes/adds/changes/removes

  1. Removal of default values for parameters from descriptions in each respective module+
  2. Fixes AB#25494

Breaking Changes

N/A

Testing Evidence

N/A

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Dec 22, 2022
@4pplied
Copy link
Contributor Author

4pplied commented Jan 3, 2023

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@4pplied
Copy link
Contributor Author

4pplied commented Jan 3, 2023

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added bug and removed Needs: Triage 🔍 Needs triaging by the team labels Jan 4, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 2b5f599 into Azure:main Jan 4, 2023
@4pplied 4pplied deleted the defaultsinparams branch January 10, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants