Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #388 - Incorrect variable reference #390

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Nov 21, 2022

Overview/Summary

Fixes issues described in #388

This PR fixes/adds/changes/removes

  1. $ResourceGroupName doesnt exist in the example PowerShell cmdlet, it only exists inside the $inputObject object variable. So, fixed all examples in PowerShell that create Resource Groups from changing the variable of $ResourceGroupName to $inputObject.ResourceGroupName.

Breaking Changes

No breaking changes.

Testing Evidence

image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Nov 21, 2022
@oZakari
Copy link
Contributor Author

oZakari commented Nov 21, 2022

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 added Area: Non-Resource Specific and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 21, 2022
@jtracey93 jtracey93 merged commit 69d81a9 into Azure:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants