Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Bug Report - missing $ResourceGroupName declaration #388

Closed
ewouds opened this issue Nov 16, 2022 · 4 comments
Closed

🪲 Bug Report - missing $ResourceGroupName declaration #388

ewouds opened this issue Nov 16, 2022 · 4 comments

Comments

@ewouds
Copy link

ewouds commented Nov 16, 2022

Describe the bug

The variable $ResourceGroupName has never been declared.
It's only declared as a parameter in the object: $inputObject
The variable is required later when creating a resourcegroup

To Reproduce

Run module 4 with the provided Azure Powershell script

Expected behaviour

Variable is declared

Additional context

With this change it should be fine:

$ResourceGroupName = "rg-$TopLevelMGPrefix-logging-001"

$inputObject = @{
DeploymentName = 'alz-LoggingDeploy-{0}' -f (-join (Get-Date -Format 'yyyyMMddTHHMMssffffZ')[0..63])
ResourceGroupName = $ResourceGroupName

@ewouds ewouds added the bug label Nov 16, 2022
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Nov 16, 2022
@jtracey93
Copy link
Collaborator

Thanks for reporting we will fix ASAP

@jtracey93 jtracey93 added documentation and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 16, 2022
@jtracey93
Copy link
Collaborator

ADO WIT 25185

@ewouds
Copy link
Author

ewouds commented Nov 16, 2022 via email

@jtracey93
Copy link
Collaborator

Yup thanks @ewouds. Its acrosss all modules that deploy to a Resource Group scope, we will fix ASAP.

Likely fix is
image

oZakari added a commit to oZakari/ALZ-Bicep that referenced this issue Nov 21, 2022
oZakari added a commit to oZakari/ALZ-Bicep that referenced this issue Nov 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants