Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #388 - Incorrect variable reference #390

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fix #388 - Incorrect variable reference #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions infra-as-code/bicep/modules/hubNetworking/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ $inputObject = @{
TemplateParameterFile = "infra-as-code/bicep/modules/hubNetworking/parameters/hubNetworking.parameters.all.json"
}

New-AzResourceGroup -Name $ResourceGroupName `
New-AzResourceGroup `
-Name $inputObject.ResourceGroupName `
-Location 'eastus'

New-AzResourceGroupDeployment @inputObject
Expand All @@ -187,7 +188,8 @@ $inputObject = @{
TemplateParameterFile = "infra-as-code/bicep/modules/hubNetworking/parameters/mc-hubNetworking.parameters.all.json"
}

New-AzResourceGroup -Name $ResourceGroupName `
New-AzResourceGroup `
-Name $inputObject.ResourceGroupName `
-Location 'chinaeast2'

New-AzResourceGroupDeployment @inputObject
Expand Down
4 changes: 2 additions & 2 deletions infra-as-code/bicep/modules/logging/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Select-AzSubscription -SubscriptionId $ManagementSubscriptionId

# Create Resource Group - optional when using an existing resource group
New-AzResourceGroup `
-Name $ResourceGroupName `
-Name $inputObject.ResourceGroupName `
-Location eastus

New-AzResourceGroupDeployment @inputObject
Expand All @@ -163,7 +163,7 @@ Select-AzSubscription -SubscriptionId $ManagementSubscriptionId

# Create Resource Group - optional when using an existing resource group
New-AzResourceGroup `
-Name $ResourceGroupName `
-Name $inputObject.ResourceGroupName `
-Location chinaeast2

New-AzResourceGroupDeployment @inputObject
Expand Down
6 changes: 4 additions & 2 deletions infra-as-code/bicep/modules/privateDnsZones/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ Select-AzSubscription -SubscriptionId $ConnectivitySubscriptionId
# Set the top level MG Prefix in accordance to your environment. This example assumes default 'alz'.
$TopLevelMGPrefix = "alz"

New-AzResourceGroup -Name $ResourceGroupName `
New-AzResourceGroup `
-Name $inputObject.ResourceGroupName `
-Location 'eastus'

$inputObject = @{
Expand All @@ -155,7 +156,8 @@ Select-AzSubscription -SubscriptionId $ConnectivitySubscriptionId
# Set the top level MG Prefix in accordance to your environment. This example assumes default 'alz'.
$TopLevelMGPrefix = "alz"

New-AzResourceGroup -Name $ResourceGroupName `
New-AzResourceGroup `
-Name $inputObject.ResourceGroupName `
-Location 'chinaeast2'

$inputObject = @{
Expand Down
6 changes: 4 additions & 2 deletions infra-as-code/bicep/modules/spokeNetworking/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ $inputObject = @{
TemplateFile = "infra-as-code/bicep/modules/spokeNetworking/spokeNetworking.bicep"
}

New-AzResourceGroup -Name $ResourceGroupName `
New-AzResourceGroup `
-Name $inputObject.ResourceGroupName `
-Location 'eastus'

New-AzResourceGroupDeployment @inputObject
Expand All @@ -156,7 +157,8 @@ $inputObject = @{
TemplateFile = "infra-as-code/bicep/modules/spokeNetworking/spokeNetworking.bicep"
}

New-AzResourceGroup -Name $ResourceGroupName `
New-AzResourceGroup `
-Name $inputObject.ResourceGroupName `
-Location 'chinaeast2'

New-AzResourceGroupDeployment @inputObject
Expand Down
4 changes: 2 additions & 2 deletions infra-as-code/bicep/modules/vnetPeering/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ $TopLevelMGPrefix = "alz"

# Create Resource Group - optional when using an existing resource group
New-AzResourceGroup `
-Name $ResourceGroupName `
-Name $inputObject.ResourceGroupName `
-Location eastus

# Parameters necessary for deployment
Expand All @@ -134,7 +134,7 @@ Select-AzSubscription -SubscriptionId $LandingZoneSubscriptionId

# Create Resource Group - optional when using an existing resource group
New-AzResourceGroup `
-Name $ResourceGroupName `
-Name $inputObject.ResourceGroupName `
-Location chinaeast2

# Set the top level MG Prefix in accordance to your environment. This example assumes default 'alz'.
Expand Down
6 changes: 4 additions & 2 deletions infra-as-code/bicep/modules/vwanConnectivity/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ $inputObject = @{
}


New-AzResourceGroup -Name $ResourceGroupName `
New-AzResourceGroup `
-Name $inputObject.ResourceGroupName `
-Location 'EastUs'

New-AzResourceGroupDeployment @inputObject
Expand All @@ -172,7 +173,8 @@ $inputObject = @{
TemplateParameterFile = "infra-as-code/bicep/modules/vwanConnectivity/parameters/mc-vwanConnectivity.parameters.all.json"
}

New-AzResourceGroup -Name $ResourceGroupName `
New-AzResourceGroup `
-Name $inputObject.ResourceGroupName `
-Location 'chinaeast2'

New-AzResourceGroupDeployment @inputObject
Expand Down