Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PSRule To ALZ Bicep Testing #313

Merged
merged 10 commits into from
Sep 5, 2022
Merged

Add PSRule To ALZ Bicep Testing #313

merged 10 commits into from
Sep 5, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Sep 2, 2022 •
edited
Loading

Overview/Summary

This PR adds PSRule testing to ALZ-Bicep for all PRs, initially in a continue_on_error = true mode to not become a blocking issue, but will allow us to highlight issues and resolve as we progress with the project.

This PR fixes/adds/changes/removes

  1. Adds PSRule to ALZ-Bicep PR Testing

Breaking Changes

None

Testing Evidence

Linting will suffice and actions that have run on ps-rule branch on this repo can be seen as successful

As part of this Pull Request I have

BernieWhite and others added 6 commits April 25, 2022 14:43
@BernieWhite
Initial PSRule without parameter files #206 (#207)
8f4089d 
* Initial PSRule without parameter files #206

* Update triggers and reference extension

* Separate job to ignore build bicep code

* Update PSRule options to include Bicep samples
@BernieWhite
PSRule baseline and minium samples (#236)
564f6a9
@jtracey93
Merge branch 'main' into ps-rule
6a50eb1
@BernieWhite
Update exclusions and complete AZ params for PIPs (#242)
c133a43 
* Update exclusions and complete AZ params for PIPs

* Add additional comments
@BernieWhite
Final updates for merge (#252)
113e433
@jtracey93
Merge branch 'main' into ps-rule
0d0049f
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Sep 2, 2022
@jtracey93 jtracey93 requested a review from jfaurskov September 2, 2022 14:42
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jfaurskov
jfaurskov approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 2120863 into main Sep 5, 2022
@jtracey93 jtracey93 deleted the ps-rule branch September 5, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaurskov jfaurskov jfaurskov approved these changes

Assignees
No one assigned
Labels
Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtracey93 @jfaurskov @BernieWhite