Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSRule baseline and minium samples #236

Merged
merged 1 commit into from
May 22, 2022
Merged

PSRule baseline and minium samples #236

merged 1 commit into from
May 22, 2022

Conversation

BernieWhite
Copy link
Contributor

@BernieWhite BernieWhite commented May 22, 2022 •
edited
Loading

Overview/Summary

Added two samples for minimum and baseline configurations.

  • The minimum sample is the least complex and bare minimum.
  • The baseline sample should be configured so that it is Well-Architected Framework aligned.

This PR fixes/adds/changes/removes

  1. Bumped PSRule GitHub Action version.
  2. Added baseline and minimum configuration for hub networking and public ip modules.
  3. Added suppression group for minimum configuration.
  4. Added configuration sample snippets for VSCode.

There is currently some failing rules because some resources currently can't meet all the requirements of PSRule for Azure without adding parameters. We should update this head from main and then add parameters for these. I haven't added these to reduce confusion about what is happening in this PR.

Related to #206

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 22, 2022
@jtracey93 jtracey93 self-requested a review May 22, 2022 06:42
@jtracey93 jtracey93 merged commit 564f6a9 into Azure:ps-rule May 22, 2022
@BernieWhite BernieWhite deleted the bewhite/ps-rule-samples branch May 22, 2022 06:46
jtracey93 added a commit that referenced this pull request Sep 5, 2022
@jtracey93 @BernieWhite
Add PSRule To ALZ Bicep Testing (#313)
2120863 
* Initial PSRule without parameter files #206 (#207)

* Initial PSRule without parameter files #206

* Update triggers and reference extension

* Separate job to ignore build bicep code

* Update PSRule options to include Bicep samples

* PSRule baseline and minium samples (#236)

* Update exclusions and complete AZ params for PIPs (#242)

* Update exclusions and complete AZ params for PIPs

* Add additional comments

* Final updates for merge (#252)

* psrule sample fixes

* fix github linter for PSRule MD

* typo fix

* update rules

Co-authored-by: Bernie White <bewhite@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BernieWhite @jtracey93