-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial PSRule without parameter files #206 #207
Merged
jtracey93
merged 4 commits into
Azure:ps-rule
from
BernieWhite:bewhite/ps-rule-integration
Apr 25, 2022
Merged
Initial PSRule without parameter files #206 #207
jtracey93
merged 4 commits into
Azure:ps-rule
from
BernieWhite:bewhite/ps-rule-integration
Apr 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jtracey93 Initial effort without parameter files. Which I understood that you didn't want merged yet, because we would work towards snippets for deployment/ testing. Let me know if there is anything else you feel we need to do to get this PR merged. |
jtracey93
requested changes
Apr 19, 2022
jtracey93
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
jtracey93
added a commit
that referenced
this pull request
Sep 5, 2022
* Initial PSRule without parameter files #206 (#207) * Initial PSRule without parameter files #206 * Update triggers and reference extension * Separate job to ignore build bicep code * Update PSRule options to include Bicep samples * PSRule baseline and minium samples (#236) * Update exclusions and complete AZ params for PIPs (#242) * Update exclusions and complete AZ params for PIPs * Add additional comments * Final updates for merge (#252) * psrule sample fixes * fix github linter for PSRule MD * typo fix * update rules Co-authored-by: Bernie White <bewhite@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Adds integration with PSRule for Azure for testing repository code with Azure Well-Architected Framework.
Working towards #206
This PR fixes/adds/changes/removes
Breaking Changes
N/A
Testing Evidence
Modules resources are not being processed yet until we have snippets to expand them.
As part of this Pull Request I have
main
branch