Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 Policy Assignment Scopes #135

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

jtracey93
Copy link
Collaborator

Overview/Summary

Same as #131 - creating here as duplicate and will close #131 due to pipelines not running on forks currently (being worked on)

From #131
Two small errors for
Deploy-Log-Analytics --> Targets Connectivity management group --> Should target Management management group
Deny-Public-Endpoints --> Targets Landing Zone management group --> Should target Corp management group

This PR fixes/adds/changes/removes

  1. Change management group target for Deploy-Log-Analytics
  2. Change management group target for Deny-Public-Endpoints

Breaking Changes

None

Testing Evidence

Unit Tests will provide some evidence of basics as well as linting. Also see below deployment evidence below:

image

As part of this Pull Request I have

@jtracey93 jtracey93 temporarily deployed to BicepUnitTests February 8, 2022 21:24 Inactive
@jtracey93 jtracey93 temporarily deployed to BicepUnitTests February 8, 2022 21:39 Inactive
@jtracey93
Copy link
Collaborator Author

Close PR workflow didnt need to run so approving.

@jtracey93 jtracey93 merged commit 33af7f5 into main Feb 8, 2022
@jtracey93 jtracey93 deleted the update-default-pol-assingments branch February 8, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant