Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Policy Initiative management group targets #131

Closed
wants to merge 1 commit into from
Closed

Update for Policy Initiative management group targets #131

wants to merge 1 commit into from

Conversation

JimmyKarlsson112
Copy link

@JimmyKarlsson112 JimmyKarlsson112 commented Feb 8, 2022

Overview/Summary

Two small errors for
Deploy-Log-Analytics --> Targets Connectivity management group --> Should target Management management group
Deny-Public-Endpoints --> Targets LandingZone management group --> Should target Corp management group

Reference https://github.com/Azure/Enterprise-Scale/blob/main/docs/ESLZ-Policies.md

This PR fixes/adds/changes/removes

  1. Change management group target for Deploy-Log-Analytics
  2. Change management group target for Deny-Public-Endpoints

Breaking Changes

  1. If already implemented, updates for log analytics targets needs to be updated for diagnostic and azure monitor policies.

Testing Evidence

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

… to management management group instead of connectivity and the second are Deny-Public-Endpoints are target towards the corp management group instead
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Feb 8, 2022
@jtracey93 jtracey93 added Area: Policy and removed Needs: Triage 🔍 Needs triaging by the team labels Feb 8, 2022
@jtracey93 jtracey93 self-assigned this Feb 8, 2022
@jtracey93 jtracey93 self-requested a review February 8, 2022 16:12
@jtracey93
Copy link
Collaborator

Thanks for raising the PR @JimmyKarlsson112 unfortunately we have an issue with unit tests from forks so have recreated this in a PR #135 on a local branch on this repo.

Thanks for your contribution though and will call you out in release notes 👍

@jtracey93 jtracey93 closed this Feb 8, 2022
jtracey93 added a commit that referenced this pull request Feb 8, 2022
* fix 2 assignments at incorrect scopes as per #131

* update version no.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants