Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 Policy Assignment Scopes #135

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Fix 2 Policy Assignment Scopes #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
726bb0d
fix 2 assignments at incorrect scopes as per #131
jtracey93 Feb 8, 2022
b578893
update version no.
jtracey93 Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
SUMMARY: This module deploys the default Azure Landing Zone Azure Policy Assignments to the Management Group Hierarchy and also assigns the relevant RBAC.
DESCRIPTION: This module deploys the default Azure Landing Zone Azure Policy Assignments to the Management Group Hierarchy and also assigns the relevant RBAC for the system-assigned Managed Identities created for policies that require them (e.g DeployIfNotExist & Modify effect policies).
AUTHOR/S: jtracey93
VERSION: 1.0.0
VERSION: 1.0.1

*/

Expand Down Expand Up @@ -468,7 +468,7 @@ module modPolicyAssignmentIdentDeployVMBackup '../../../policy/assignments/polic
// Modules - Policy Assignments - Management Management Group
// Module - Policy Assignment - Deploy-Log-Analytics
module modPolicyAssignmentMgmtDeployLogAnalytics '../../../policy/assignments/policyAssignmentManagementGroup.bicep' = {
scope: managementGroup(varManagementGroupIDs.platformIdentity)
scope: managementGroup(varManagementGroupIDs.platformManagement)
name: varModuleDeploymentNames.modPolicyAssignmentMgmtDeployLogAnalytics
params: {
parPolicyAssignmentDefinitionID: varPolicyAssignmentDeployLogAnalytics.definitionID
Expand Down Expand Up @@ -737,7 +737,7 @@ module modPolicyAssignmentLZsDeploySQLThreat '../../../policy/assignments/policy
// Modules - Policy Assignments - Corp Management Group
// Module - Policy Assignment - Deny-Public-Endpoints
module modPolicyAssignmentLZsDenyPublicEndpoints '../../../policy/assignments/policyAssignmentManagementGroup.bicep' = {
scope: managementGroup(varManagementGroupIDs.landingZones)
scope: managementGroup(varManagementGroupIDs.landingZonesCorp)
name: varModuleDeploymentNames.modPolicyAssignmentLZsDenyPublicEndpoints
params: {
parPolicyAssignmentDefinitionID: varPolicyAssignmentDenyPublicEndpoints.definitionID
Expand Down