Gutenberg: remove remaining usages of wordpress/nux package #28267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindl
added
[Status] Needs Review
We don't use core guided tour in Calypso so we don't need the DotTip component from this package. Since this is the last remaining usage, I'm cleaning up the whole packge so we don't have to worry about it in future renovate updates.
vindl
force-pushed
the
update/clean-up-wordpress-nux
branch
from
97d26e2 to
34e3f19
Compare
Unfortunately we still need to keep this to prevent the tips from popping up (test with clear cache). The reason behind that is that some are loaded by components package implicitly.
Nice catch! I removed those in 34e3f19. |
Copons
approved these changes
Nov 6, 2018
Copons
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Follow up for #28260.
We don't use core guided tour in Calypso so we don't need the DotTip component from this package. Since this is the last remaining usage, I'm removing the package dependency so we don't have to worry about it in future renovate updates.
Here is one example where it broke the editor during package updates #28000 (comment).
Testing instructions
@wordpress/nuxpackage in Calypso's codebase.