Skip to content

Commit

Permalink
Gutenberg: remove remaining usages of wordpress/nux package (#28267)
Browse files Browse the repository at this point in the history
We don't use core guided tour in Calypso so we don't need the DotTip
component from this package. Since this is the last remaining usage,
I'm cleaning up the whole package so we don't have to worry about it
in future renovate updates.
  • Loading branch information
vindl authored Nov 6, 2018
1 parent 8ed68be commit b281bc2
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 54 deletions.
8 changes: 2 additions & 6 deletions client/gutenberg/editor/edit-post/components/header/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { IconButton } from '@wordpress/components';
import { PostPreviewButton, PostSavedState } from '@wordpress/editor';
import { withDispatch, withSelect } from '@wordpress/data';
import { compose } from '@wordpress/compose';
import { DotTip } from '@wordpress/nux';

/**
* Internal dependencies
Expand All @@ -32,6 +31,7 @@ function Header( {
} ) {
const toggleGeneralSidebar = isEditorSidebarOpened ? closeGeneralSidebar : openGeneralSidebar;

/* eslint-disable wpcalypso/jsx-classname-namespace */
return (
<div
role="region"
Expand All @@ -55,18 +55,14 @@ function Header( {
aria-expanded={ isEditorSidebarOpened }
shortcut={ shortcuts.toggleSidebar }
/>
<DotTip tipId="core/editor.settings">
{ __(
'You’ll find more settings for your page and blocks in the sidebar. Click “Settings” to open it.'
) }
</DotTip>
</div>
<PinnedPlugins.Slot />
<MoreMenu />
</div>
) }
</div>
);
/* eslint-enable wpcalypso/jsx-classname-namespace */
}

export default compose(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { IconButton, Dropdown, MenuGroup } from '@wordpress/components';
import ModeSwitcher from '../mode-switcher';
import FixedToolbarToggle from '../fixed-toolbar-toggle';
import PluginMoreMenuGroup from '../plugins-more-menu-group';
import TipsToggle from '../tips-toggle';

/* eslint-disable wpcalypso/jsx-classname-namespace */
const MoreMenu = () => (
Expand All @@ -38,7 +37,6 @@ const MoreMenu = () => (
filterName="editPost.MoreMenu.settings"
>
<FixedToolbarToggle onToggle={ onClose } />
<TipsToggle onToggle={ onClose } />
</MenuGroup>
<PluginMoreMenuGroup.Slot fillProps={ { onClose } } />
<MenuGroup
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"@wordpress/hooks": "2.0.3",
"@wordpress/i18n": "3.0.1",
"@wordpress/keycodes": "2.0.3",
"@wordpress/nux": "2.0.9",
"@wordpress/plugins": "2.0.6",
"@wordpress/rich-text": "2.0.2",
"@wordpress/url": "2.2.0",
Expand Down

0 comments on commit b281bc2

Please sign in to comment.