Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: show correct button when editing a post #28260

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Gutenberg: show correct button when editing a post #28260

merged 1 commit into from
Nov 4, 2018

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Nov 2, 2018

Changes proposed in this Pull Request

  • This updates header to match what's in Gutenberg master. We had gotten too out of sync with edit-post and a recent wpcom update broke our ability to update posts. We should audit later on what other files we need to manually update that we aren't pulling in from the edit-post package.

If folks approve this PR. Please also LAND. This is a blocker for Horizon testing.

If folks don't approve, y'all are welcome to work on this PR/commit directly + move it forward.

screen shot 2018-11-02 at 4 30 54 pm

Testing instructions

  • Checkout this branch
  • Visit /gutenberg/post
  • Select a simple site that has been stickered to enable Gutenberg code to load
  • Create a post and publish
  • Make additional changes (note that the publish button has been changed to Update)
  • Clicking on update reflects new changes.

Fixes #28246

@gwwar gwwar added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Nov 2, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/update-post

@gwwar gwwar self-assigned this Nov 2, 2018
@gwwar gwwar requested review from a team November 2, 2018 23:38
@vindl vindl self-assigned this Nov 4, 2018
vindl
vindl approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@vindl vindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@vindl vindl added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 4, 2018
@vindl vindl merged commit 6a9140c into master Nov 4, 2018
@vindl vindl deleted the fix/update-post branch November 4, 2018 04:56
@vindl vindl mentioned this pull request Nov 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vindl vindl vindl approved these changes

Assignees

@vindl vindl

@gwwar gwwar

Labels
[Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwwar @matticbot @vindl