Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote: Core block settings #5574

Merged
merged 10 commits into from
Feb 25, 2022
Merged

Remote: Core block settings #5574

merged 10 commits into from
Feb 25, 2022

Conversation

matiasbenedetto
Copy link
Member

@matiasbenedetto matiasbenedetto commented Feb 22, 2022

Changes proposed in this Pull Request:

  • Remote: Button styles
  • Remote: Link Styles

Related issue(s):

Remote: Core block settings

@matiasbenedetto matiasbenedetto linked an issue Feb 22, 2022 that may be closed by this pull request
remote/style.css Outdated
@@ -97,13 +97,100 @@ body > .is-root-container,
padding-left: var(--wp--custom--spacing--outer);
}

/* Button styles */
.wp-block-search__button,
.wp-block-button__link,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, for example to target the buttons added in the editor using "Buttons" block.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are controlled by the theme.json file, so they don't need to be targetted here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove the right line? I thought it was wp-block-button__link we should remove...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

@scruffian
Copy link
Member

There's still a border on this button that I think we need to get rid of:
Screenshot 2022-02-23 at 16 09 32

@matiasbenedetto
Copy link
Member Author

I think with the latest commit the border issue should be solved.

remote/style.css Outdated
}

:is(
a,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this selector is unnecessarily affecting the site title on hover + active:

Screen Shot 2022-02-23 at 11 21 57 AM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be fixed with the last commit

@scruffian
Copy link
Member

This is looking good. I added a commit for padding on the buttons block so that they match:

Screenshot 2022-02-25 at 09 10 42

@matiasbenedetto matiasbenedetto merged commit 539a44d into trunk Feb 25, 2022
@scruffian scruffian deleted the update/5509 branch February 25, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote: Core block settings (if needed)
3 participants