Buttons: Don't set a placeholder text color #39034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -79 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
jffng
reviewed
Feb 23, 2022
There was a problem hiding this comment.
I tested this across a variety of themes and it either had no effect (twentynineteen - twentytwentytwo) or fixed things when it was a "dark" theme (Remote, Geologist).
Makes sense to me, but I'm curious as to why this was added in the first place and if we'd be breaking anything by removing it. Did the placeholder text color not always inherit the block's color?
I think so yeah. The fix was added in 2018, so a lot of stuff has happened since then. |
jasmussen
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts https://github.com/WordPress/gutenberg/pull/10160/files, since it's no longer needed. The problem with this fix is that it doesn't account for light buttons in a dark theme. Since now the placeholder inherits the block colors we don't need to set a placeholder color at all, so I think we can just remove these lines.
Testing Instructions
Use remote: Automattic/themes#5574
Add a Button block to a post
Confirm that the placeholder text is still legible.
Screenshots
Before
After
TT2 is unaffected by this change:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).